No need to fetch whole network object on port create

Bug #1917866 reported by Oleg Bondarev
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Oleg Bondarev

Bug Description

DB plugin checks for network existence during port create:
https://github.com/openstack/neutron/blob/cb64e3a19fdddb3eac593114a482c9dd69be68d5/neutron/db/db_base_plugin_v2.py#L1422

There is no need to fetch the whole net object (which leads to several heavy DB requests according to OSProfiler stats) when only need to check net existence.

Changed in neutron:
assignee: nobody → Oleg Bondarev (obondarev)
importance: Undecided → Wishlist
tags: added: loadimpact
Revision history for this message
Oleg Bondarev (obondarev) wrote :
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.0.0.0rc1

This issue was fixed in the openstack/neutron 18.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/787479

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/787481

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/787482

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787479
Committed: https://opendev.org/openstack/neutron/commit/29e36009bbb25a2e3d66b3746d590e4046626d2c
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 29e36009bbb25a2e3d66b3746d590e4046626d2c
Author: Oleg Bondarev <email address hidden>
Date: Fri Mar 5 15:02:23 2021 +0400

    Check for existence instead of fetching the whole net object

    There is no need to fetch the whole net object
    (which leads to several heavy DB requests according
    to OSProfiler stats) when only need to check net existence

    This speeds up port creation up to 15%

    Closes-Bug: #1917866
    Change-Id: I75db7c713a17a0f1b1b5aecc6eec93e636a71827
    (cherry picked from commit 4bb3c92917cdf19b18c7481786050241218e8df7)

tags: added: in-stable-victoria
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787482
Committed: https://opendev.org/openstack/neutron/commit/863a6d1f7c641c9aeaa7802bd64a314c3b970779
Submitter: "Zuul (22348)"
Branch: stable/train

commit 863a6d1f7c641c9aeaa7802bd64a314c3b970779
Author: Oleg Bondarev <email address hidden>
Date: Fri Mar 5 15:02:23 2021 +0400

    Check for existence instead of fetching the whole net object

    There is no need to fetch the whole net object
    (which leads to several heavy DB requests according
    to OSProfiler stats) when only need to check net existence

    This speeds up port creation up to 15%

    Closes-Bug: #1917866
    Change-Id: I75db7c713a17a0f1b1b5aecc6eec93e636a71827
    (cherry picked from commit 4bb3c92917cdf19b18c7481786050241218e8df7)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787481
Committed: https://opendev.org/openstack/neutron/commit/5e4a8fbb0ee95239d1221726a559e40aaa290be5
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 5e4a8fbb0ee95239d1221726a559e40aaa290be5
Author: Oleg Bondarev <email address hidden>
Date: Fri Mar 5 15:02:23 2021 +0400

    Check for existence instead of fetching the whole net object

    There is no need to fetch the whole net object
    (which leads to several heavy DB requests according
    to OSProfiler stats) when only need to check net existence

    This speeds up port creation up to 15%

    Closes-Bug: #1917866
    Change-Id: I75db7c713a17a0f1b1b5aecc6eec93e636a71827
    (cherry picked from commit 4bb3c92917cdf19b18c7481786050241218e8df7)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.3.4

This issue was fixed in the openstack/neutron 15.3.4 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.3.2

This issue was fixed in the openstack/neutron 16.3.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.1.2

This issue was fixed in the openstack/neutron 17.1.2 release.

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Fix merged and released.

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.