In "test_dvr_router_lifecycle_ha_with_snat_with_fips", the HA proxy PID file is not removed

[Rodolfo Alonso]

During the execution of "test_dvr_router_lifecycle_ha_with_snat_with_fips", when the router is deleted, the metadata proxy PID file is not removed.

Logs: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bb0/769390/2/check/neutron-functional-with-uwsgi/bb00724/testr_results.html

Snippet: http://paste.openstack.org/show/801503/

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Another occurrence: https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_44b/763231/13/check/neutron-functional-with-uwsgi/44b98e8/testr_results.html

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Related patch: https://review.opendev.org/c/openstack/neutron/+/773778

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.3.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.0.0.0rc1 release candidate.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/776451
Committed: https://opendev.org/openstack/neutron/commit/d8d9c1c7e8f5bbf002542411478677d83113cd3d
Submitter: "Zuul (22348)"
Branch: stable/train

commit d8d9c1c7e8f5bbf002542411478677d83113cd3d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Feb 2 17:25:03 2021 +0000

    Stop metadata proxy gracefully

    HAProxy supports hard stop [1] via SIGTERM signal. From the
    documentation:

      """
      ... when the SIGTERM signal is sent to the haproxy process,
      it immediately quits and all established connections are
      closed.
      """

    In case the process does not finish, the SIGKILL signal is sent.
    The PID file created by the process is deleted.

    [1]https://cbonte.github.io/haproxy-dconv/2.0/management.html#4

    Closes-Bug: #1910691

    Conflicts:
        neutron/agent/metadata/driver.py
        neutron/tests/unit/agent/dhcp/test_agent.py
        neutron/tests/unit/agent/metadata/test_driver.py

    Change-Id: Ifa3734e8eb4e52b1a132c3351ecc2e15463298bb
    (cherry picked from commit bf14c725bbb6ce710a45c55d1dd00eee2fb53f62)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 15.3.4 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 17.1.2 release.