Enforce security group cleanup (Resources leaks)

[Abhishek Jaiswal]

Enforce security group rule cleanup if created in the test case

This will avoid clashes with other test cases running in the same
thread

FAIL 0:00:16.259435 neutron_tempest_plugin.api.test_security_groups.SecGroupRulesQuotaTest.test_create_sg_rules_when_quota_disabled[id-4459e066-d9c8-4a13-9e98-018f95ce2dbf]

Traceback:
Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/neutron_tempest_plugin/api/test_security_groups.py", line 314, in test_create_sg_rules_when_quota_disabled
    self._create_security_group_rules(10, port_index=100)
  File "/usr/local/lib/python3.6/dist-packages/neutron_tempest_plugin/api/test_security_groups.py", line 233, in _create_security_group_rules
    'protocol': 'tcp'})
  File "/usr/local/lib/python3.6/dist-packages/neutron_tempest_plugin/api/base.py", line 874, in create_security_group_rule
    return client.create_security_group_rule(**kwargs)[
  File "/usr/local/lib/python3.6/dist-packages/neutron_tempest_plugin/services/network/json/network_client.py", line 913, in create_security_group_rule
    resp, body = self.post(uri, body)
  File "/home/aqua/tempest/tempest/lib/common/rest_client.py", line 298, in post
    return self.request('POST', url, extra_headers, headers, body, chunked)
  File "/home/aqua/tempest/tempest/lib/common/rest_client.py", line 702, in request
    self._error_checker(resp, resp_body)
  File "/home/aqua/tempest/tempest/lib/common/rest_client.py", line 823, in _error_checker
    raise exceptions.Conflict(resp_body, resp=resp)
tempest.lib.exceptions.Conflict: Conflict with state of target resource
Details: {'type': 'SecurityGroupRuleExists', 'message': 'Security group rule already exists. Rule id is dcf10cc5-5b0c-4be2-81e8-62d7a226b620.', 'detail': ''}

[Jakub Libosvar (libosvar)]

Hi Abhishek, thanks for the bug report. Is this meant to go to tempest tests?

[Jakub Libosvar (libosvar)]

Hi Abhishek, is the fix supposed to go to cleanup parts of tempest? Where do you see such error?

[Abhishek Jaiswal (jkabhishek)]

HI @libosvar there is already a commit made by me https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/762104

[Oleg Bondarev (obondarev)]

Fix: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/762104

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Bug closed due to lack of activity, please feel free to reopen if needed.

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Abhishek Jaiswal <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/762104