Activity log for bug #1904399

Date Who What changed Old value New value Message
2020-11-16 10:12:58 Lucas Alvares Gomes bug added bug
2020-11-16 10:13:04 Lucas Alvares Gomes neutron: assignee Lucas Alvares Gomes (lucasagomes)
2020-11-16 10:13:11 Lucas Alvares Gomes neutron: importance Undecided Medium
2020-11-16 10:13:14 Lucas Alvares Gomes neutron: importance Medium High
2020-11-16 10:13:25 Lucas Alvares Gomes neutron: importance High Medium
2020-11-16 10:56:03 OpenStack Infra neutron: status New In Progress
2021-02-08 16:43:08 Corey Bryant bug task added neutron (Ubuntu)
2021-02-08 16:43:33 Corey Bryant nominated for series Ubuntu Hirsute
2021-02-08 16:43:33 Corey Bryant bug task added neutron (Ubuntu Hirsute)
2021-02-08 16:43:33 Corey Bryant nominated for series Ubuntu Focal
2021-02-08 16:43:33 Corey Bryant bug task added neutron (Ubuntu Focal)
2021-02-08 16:43:33 Corey Bryant nominated for series Ubuntu Groovy
2021-02-08 16:43:33 Corey Bryant bug task added neutron (Ubuntu Groovy)
2021-02-08 16:44:25 Corey Bryant neutron (Ubuntu Hirsute): status New Fix Released
2021-02-08 16:52:25 Corey Bryant neutron (Ubuntu Groovy): status New Triaged
2021-02-08 16:52:29 Corey Bryant neutron (Ubuntu Focal): status New Triaged
2021-02-08 16:52:43 Corey Bryant neutron: status In Progress Fix Released
2021-02-08 16:54:16 Corey Bryant neutron (Ubuntu Focal): importance Undecided High
2021-02-08 16:54:19 Corey Bryant neutron (Ubuntu Groovy): importance Undecided High
2021-02-08 17:36:27 Corey Bryant bug task added cloud-archive
2021-02-08 17:36:39 Corey Bryant nominated for series cloud-archive/ussuri
2021-02-08 17:36:39 Corey Bryant bug task added cloud-archive/ussuri
2021-02-08 17:36:39 Corey Bryant nominated for series cloud-archive/victoria
2021-02-08 17:36:39 Corey Bryant bug task added cloud-archive/victoria
2021-02-08 17:36:47 Corey Bryant cloud-archive/victoria: status New Triaged
2021-02-08 17:36:51 Corey Bryant cloud-archive/ussuri: status New Triaged
2021-02-08 17:36:55 Corey Bryant cloud-archive/ussuri: importance Undecided High
2021-02-08 17:37:00 Corey Bryant cloud-archive/victoria: importance Undecided High
2021-02-08 20:41:16 Corey Bryant description ML2/OVN reuses the same "[ovs]/igmp_snooping_enable" configuration option from ML2/OVS, which says [0]: "Setting this option to True will also enable Open vSwitch mcast-snooping-disable-flood-unregistered flag. This option will disable flooding of unregistered multicast packets to all ports." But, that's not true for ML2/OVN, in fact, this is the opposite because ML2/OVN does have the option to flood to unregistered VMs enabled by default. In order to keep the consistent between both drivers and this configuration option, ML2/OVN needs to disable the "mcast_flood_unregistered" configuration in the other_config column from the Logical Switch table when igmp_snooping_enable is True. [0] https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36-L47 ML2/OVN reuses the same "[ovs]/igmp_snooping_enable" configuration option from ML2/OVS, which says [0]: "Setting this option to True will also enable Open vSwitch mcast-snooping-disable-flood-unregistered flag. This option will disable flooding of unregistered multicast packets to all ports." But, that's not true for ML2/OVN, in fact, this is the opposite because ML2/OVN does have the option to flood to unregistered VMs enabled by default. In order to keep the consistent between both drivers and this configuration option, ML2/OVN needs to disable the "mcast_flood_unregistered" configuration in the other_config column from the Logical Switch table when igmp_snooping_enable is True. [0] https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36-L47 [Impact] See above. [Test Case] root@f1:/usr/lib/python3/dist-packages# python3 -m unittest neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestDBInconsistenciesPeriodics.test_check_for_igmp_snoop_support I would also like to get test feedback from Canonical bootstack as they are hitting this issue. [Regression Potential] This is a very minimal and targeted change that always hard codes MCAST_FLOOD_UNREGISTERED to 'false'. In assessing regression potential for changes like this, one that comes to mind is potential of a type error when setting MCAST_FLOOD_UNREGISTERED. Upon visual inspection of this code fix, a type error would be impossible, as what was once set to a 'true' or 'false' value is now set to 'false'. Another thought is whether MCAST_FLOOD_UNREGISTERED has any use if MCAST_SNOOP is set to false, but that is not the case according to upstream OVN documentation which states: mcast_flood_unregistered: optional string, either true or false Determines whether unregistered multicast traffic should be flooded or not. Only applicable if other_config:mcast_snoop is enabled.
2021-02-08 20:41:27 Corey Bryant bug added subscriber Ubuntu Stable Release Updates Team
2021-02-08 20:43:11 Corey Bryant description ML2/OVN reuses the same "[ovs]/igmp_snooping_enable" configuration option from ML2/OVS, which says [0]: "Setting this option to True will also enable Open vSwitch mcast-snooping-disable-flood-unregistered flag. This option will disable flooding of unregistered multicast packets to all ports." But, that's not true for ML2/OVN, in fact, this is the opposite because ML2/OVN does have the option to flood to unregistered VMs enabled by default. In order to keep the consistent between both drivers and this configuration option, ML2/OVN needs to disable the "mcast_flood_unregistered" configuration in the other_config column from the Logical Switch table when igmp_snooping_enable is True. [0] https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36-L47 [Impact] See above. [Test Case] root@f1:/usr/lib/python3/dist-packages# python3 -m unittest neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestDBInconsistenciesPeriodics.test_check_for_igmp_snoop_support I would also like to get test feedback from Canonical bootstack as they are hitting this issue. [Regression Potential] This is a very minimal and targeted change that always hard codes MCAST_FLOOD_UNREGISTERED to 'false'. In assessing regression potential for changes like this, one that comes to mind is potential of a type error when setting MCAST_FLOOD_UNREGISTERED. Upon visual inspection of this code fix, a type error would be impossible, as what was once set to a 'true' or 'false' value is now set to 'false'. Another thought is whether MCAST_FLOOD_UNREGISTERED has any use if MCAST_SNOOP is set to false, but that is not the case according to upstream OVN documentation which states: mcast_flood_unregistered: optional string, either true or false Determines whether unregistered multicast traffic should be flooded or not. Only applicable if other_config:mcast_snoop is enabled. ML2/OVN reuses the same "[ovs]/igmp_snooping_enable" configuration option from ML2/OVS, which says [0]: "Setting this option to True will also enable Open vSwitch mcast-snooping-disable-flood-unregistered flag. This option will disable flooding of unregistered multicast packets to all ports." But, that's not true for ML2/OVN, in fact, this is the opposite because ML2/OVN does have the option to flood to unregistered VMs enabled by default. In order to keep the consistent between both drivers and this configuration option, ML2/OVN needs to disable the "mcast_flood_unregistered" configuration in the other_config column from the Logical Switch table when igmp_snooping_enable is True. [0] https://opendev.org/openstack/neutron/src/branch/master/neutron/conf/agent/ovs_conf.py#L36-L47 [Impact] See above. [Test Case] Run the following and expect success: root@f1:~# sudo apt install python3-neutron root@f1:/usr/lib/python3/dist-packages# python3 -m unittest neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_maintenance.TestDBInconsistenciesPeriodics.test_check_for_igmp_snoop_support I would also like to get test feedback from Canonical bootstack as they are hitting this issue. [Regression Potential] This is a very minimal and targeted change that always hard codes MCAST_FLOOD_UNREGISTERED to 'false'. In assessing regression potential for changes like this, one that comes to mind is potential of a type error when setting MCAST_FLOOD_UNREGISTERED. Upon visual inspection of this code fix, a type error would be impossible, as what was once set to a 'true' or 'false' value is now set to 'false'. Another thought is whether MCAST_FLOOD_UNREGISTERED has any use if MCAST_SNOOP is set to false, but that is not the case according to upstream OVN documentation which states: mcast_flood_unregistered: optional string, either true or false Determines whether unregistered multicast traffic should be flooded or not. Only applicable if other_config:mcast_snoop is enabled.
2021-02-09 20:29:10 Brian Murray neutron (Ubuntu Groovy): status Triaged Fix Committed
2021-02-09 20:29:16 Brian Murray bug added subscriber SRU Verification
2021-02-09 20:29:22 Brian Murray tags ovn ovn verification-needed verification-needed-groovy
2021-02-09 20:30:54 Brian Murray neutron (Ubuntu Focal): status Triaged Fix Committed
2021-02-09 20:31:03 Brian Murray tags ovn verification-needed verification-needed-groovy ovn verification-needed verification-needed-focal verification-needed-groovy
2021-02-10 14:19:02 Corey Bryant cloud-archive/victoria: status Triaged Fix Committed
2021-02-10 14:19:05 Corey Bryant tags ovn verification-needed verification-needed-focal verification-needed-groovy ovn verification-needed verification-needed-focal verification-needed-groovy verification-victoria-needed
2021-02-17 13:06:46 Corey Bryant cloud-archive/ussuri: status Triaged Fix Committed
2021-02-17 13:06:49 Corey Bryant tags ovn verification-needed verification-needed-focal verification-needed-groovy verification-victoria-needed ovn verification-needed verification-needed-focal verification-needed-groovy verification-ussuri-needed verification-victoria-needed
2021-02-24 16:51:59 Corey Bryant tags ovn verification-needed verification-needed-focal verification-needed-groovy verification-ussuri-needed verification-victoria-needed ovn verification-done verification-done-focal verification-done-groovy verification-ussuri-done verification-victoria-done
2021-03-01 10:47:27 Ɓukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2021-03-01 10:57:31 Launchpad Janitor neutron (Ubuntu Groovy): status Fix Committed Fix Released
2021-03-01 11:03:00 Launchpad Janitor neutron (Ubuntu Focal): status Fix Committed Fix Released
2021-03-01 15:40:30 Corey Bryant cloud-archive/victoria: status Fix Committed Fix Released
2021-03-01 15:40:57 Corey Bryant cloud-archive/ussuri: status Fix Committed Fix Released
2021-03-10 12:46:29 Nobuto Murata bug added subscriber Nobuto Murata