[OVN] neutron db sync does not sync external_ids for routes

[Benjamin Reichel]

During syncing neutron db with ovn the external_ids in the routes are not properly synced as in the usual creation process. Missing entries are external_ids with "neutron:is_ext_gw" and "neutron:subnet_id".

Northbound Logical_Router_Static_Route entries before the sync:

_uuid : 0b7e38b0-85cf-4a47-894c-7f5add6f564c
external_ids : {"neutron:is_ext_gw"="true", "neutron:subnet_id"="96847434-e96a-4e2b-878f-790fd34b1624"}
ip_prefix : "0.0.0.0/0"
nexthop : "<provider_gw_ip>"
options : {}
output_port : []
policy : []

Northbound Logical_Router_Static_Route entries after the syncing the db from scratch:

_uuid : 9a55d25e-d334-4f9c-bc78-067aee0c90c0
external_ids : {}
ip_prefix : "0.0.0.0/0"
nexthop : "<provider_gw_ip>"
options : {}
output_port : []
policy : []

This will break update/delete routes procedures on the routers.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/761420

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/761420
Committed: https://opendev.org/openstack/neutron/commit/43c60d6216623b49b3096f4865d89f4705345ed7
Submitter: "Zuul (22348)"
Branch: master

commit 43c60d6216623b49b3096f4865d89f4705345ed7
Author: Benjamin Reichel <email address hidden>
Date: Wed Nov 4 15:42:54 2020 +0100

    Syncing neutron db with ovn does not provide external_ids for static routes

    This change adds external_ids to the static routes in case the route is of
    type gateway_ip during ovn_db_sync.

    Change-Id: I17795b9986aa8655f5467dca0fb4e3cd5cb82252
    Closes-Bug: #1902888

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 19.0.0.0rc1 release candidate.