[OVN Octavia Provider] OVN provider loadbalancer failover should fail as unsupported

[Brian Haley]

The core OVN code for Loadbalancers does not support a manual failover from one gateway node to another. But running the command with the OVN provider driver seems to succeed:

$ openstack loadbalancer failover $ID
(no output)

The code actually does nothing and just returns the provisioning status as ACTIVE.

Since it's unsupported by the underlying technology, the provider driver should return an UnsupportedOptionError() to the caller.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/760209

[Brian Haley (brian-haley)]

https://review.opendev.org/760209 merged

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ovn-octavia-provider 1.0.0 release.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827296

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827317

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Fernando Royo <email address hidden>" on branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827317
Reason: Error in commit message (--amend by error)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827324

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827324
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/49ff17b04da7c8dfb7088f0378e6dac569e05fe0
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit 49ff17b04da7c8dfb7088f0378e6dac569e05fe0
Author: Fernando Royo <email address hidden>
Date: Tue Feb 1 17:53:00 2022 +0100

    Return UnsupportedOptionError() on loadbalancer failover

    The core OVN code for Loadbalancers does not support a
    manual failover from one gateway node to another. But
    running the command with the OVN provider driver seems
    to succeed:

    $ openstack loadbalancer failover $ID
    (no output)

    The code actually does nothing and just returns the
    provisioning status as ACTIVE.

    Since it's unsupported by the underlying technology,
    have the provider driver return an UnsupportedOptionError().

    Closes-bug: #1901936
    (manually cherry picked from commit a238fafcbf4e9466b93151f6c23821d5fdc21dcc)

    Change-Id: Idad698745233d418eb24f244ab304ce37dc09361

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/ovn-octavia-provider/+/827296
Committed: https://opendev.org/openstack/ovn-octavia-provider/commit/8392ac8475f230d5950d48ad483592655d1519e0
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 8392ac8475f230d5950d48ad483592655d1519e0
Author: Brian Haley <email address hidden>
Date: Wed Oct 28 15:02:19 2020 -0400

    Return UnsupportedOptionError() on loadbalancer failover

    The core OVN code for Loadbalancers does not support a
    manual failover from one gateway node to another. But
    running the command with the OVN provider driver seems
    to succeed:

    $ openstack loadbalancer failover $ID
    (no output)

    The code actually does nothing and just returns the
    provisioning status as ACTIVE.

    Since it's unsupported by the underlying technology,
    have the provider driver return an UnsupportedOptionError().

    Change-Id: I6b41b59919494cb428e7429dea8160b4c958fa76
    Closes-bug: #1901936
    (cherry picked from commit a238fafcbf4e9466b93151f6c23821d5fdc21dcc)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn train-eol release.