TestOvnDbNotifyHandler test cases failing due to missing attribute "_RowEventHandler__watched_events"

[Rodolfo Alonso]

Some neutron.tests.unit.plugins.ml2.drivers.ovn.mech_driver.ovsdb.test_ovsdb_monitor.TestOvnDbNotifyHandler test cases are failing:
* test_shutdown
* test_watch_and_unwatch_events

The error [1] is caused because of a missing attribute:
  AttributeError: 'OvnDbNotifyHandler' object has no attribute '_RowEventHandler__watched_events'

[1]https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_bec/periodic/opendev.org/openstack/neutron/master/openstack-tox-py36-with-ovsdbapp-master/becf062/testr_results.html

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

I think I found the culprit: https://review.opendev.org/#/c/752797/

I'll push a patch for this.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/755335

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

ovsdbapp patch [1] is still in master, not in the latest repository tag (1.5.0). We need to bump ovsdbapp version to include this patch and then, the Neutron fix [2] could be applied.

For now I'll push a temporary patch accepting both assignations with a NOTE to delete the former one once the ovsdbapp lib version is bumped.

[1]https://review.opendev.org/#/c/752797/
[2]https://review.opendev.org/755335

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755335
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ac08e89124bd7aad532e86b12a1e67b9550387ef
Submitter: Zuul
Branch: master

commit ac08e89124bd7aad532e86b12a1e67b9550387ef
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 30 15:59:22 2020 +0000

    Change reference to OvnDbNotifyHandler._watched_events

    Since [1], RowEventHandler._watched_events do not use name mangling.
    OvnDbNotifyHandler, inheriting from RowEventHandler, can access to
    this variable.

    [1]https://review.opendev.org/#/c/752797/

    Change-Id: I545c31977799c4ea51e037b631a49306da9c4a3b
    Partial-Bug: #1897928

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/755924

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755924
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2668ae348b0abfe66075258eece49122164726c3
Submitter: Zuul
Branch: stable/victoria

commit 2668ae348b0abfe66075258eece49122164726c3
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 30 15:59:22 2020 +0000

    Change reference to OvnDbNotifyHandler._watched_events

    Since [1], RowEventHandler._watched_events do not use name mangling.
    OvnDbNotifyHandler, inheriting from RowEventHandler, can access to
    this variable.

    [1]https://review.opendev.org/#/c/752797/

    Change-Id: I545c31977799c4ea51e037b631a49306da9c4a3b
    Partial-Bug: #1897928

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/787606

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/787606
Committed: https://opendev.org/openstack/neutron/commit/ffe416c0c0d6212fde0727bf6593280222cf1e95
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit ffe416c0c0d6212fde0727bf6593280222cf1e95
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 30 15:59:22 2020 +0000

    Change reference to OvnDbNotifyHandler._watched_events

    Since [1], RowEventHandler._watched_events do not use name mangling.
    OvnDbNotifyHandler, inheriting from RowEventHandler, can access to
    this variable.

    [1]https://review.opendev.org/#/c/752797/

    Change-Id: I545c31977799c4ea51e037b631a49306da9c4a3b
    Partial-Bug: #1897928
    (cherry picked from commit ac08e89124bd7aad532e86b12a1e67b9550387ef)

[Brian Haley (brian-haley)]

Seems to have been fixed with https://review.opendev.org/c/openstack/neutron/+/820911 will close this bug.