Unnecessary error log when checking if a device is ready

Bug #1896920 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Wishlist
Rodolfo Alonso

Bug Description

In method "ensure_device_is_ready" [1], if the device does not exist or the MAC is still not assigned, the method returns False and also logs an error. This error log is distracting; instead of this, an info message could be logged.

The code using this method, that returns True or False depending on the state of the interface, can decide to log a higher log message.

[1]https://github.com/openstack/neutron/blob/856cae4cf8e33c05b308d880df78b7be02ae90ad/neutron/agent/linux/ip_lib.py#L955

Changed in neutron:
importance: Undecided → Low
importance: Low → Wishlist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/754005

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/754005
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c
Submitter: Zuul
Branch: master

commit b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 23 16:35:45 2020 +0000

    Reduce log level in "ensure_device_is_ready"

    If the device is not ready, the method should inform about this
    event. The code calling this method, if needed, can write a higher
    log message.

    Change-Id: Ib7c5ba736f6e4ccc88df665faeef304c176a24e7
    Closes-Bug: #1896920

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 18.0.0.0rc1

This issue was fixed in the openstack/neutron 18.0.0.0rc1 release candidate.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/c/openstack/neutron/+/823360

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/victoria)

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/c/openstack/neutron/+/823361

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/c/openstack/neutron/+/823362

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/victoria)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823361
Committed: https://opendev.org/openstack/neutron/commit/993597d998f0ae9df3774e560f51589da1291d7a
Submitter: "Zuul (22348)"
Branch: stable/victoria

commit 993597d998f0ae9df3774e560f51589da1291d7a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 23 16:35:45 2020 +0000

    Reduce log level in "ensure_device_is_ready"

    If the device is not ready, the method should inform about this
    event. The code calling this method, if needed, can write a higher
    log message.

    Change-Id: Ib7c5ba736f6e4ccc88df665faeef304c176a24e7
    Closes-Bug: #1896920
    (cherry picked from commit b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c)

tags: added: in-stable-victoria
tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823362
Committed: https://opendev.org/openstack/neutron/commit/ee794994d5b7cd3e049a3d68e4cc07ed7cf121d7
Submitter: "Zuul (22348)"
Branch: stable/ussuri

commit ee794994d5b7cd3e049a3d68e4cc07ed7cf121d7
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 23 16:35:45 2020 +0000

    Reduce log level in "ensure_device_is_ready"

    If the device is not ready, the method should inform about this
    event. The code calling this method, if needed, can write a higher
    log message.

    Change-Id: Ib7c5ba736f6e4ccc88df665faeef304c176a24e7
    Closes-Bug: #1896920
    (cherry picked from commit b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/c/openstack/neutron/+/823360
Committed: https://opendev.org/openstack/neutron/commit/5d6faee55fdf110d6561e23ec13f3753b493dc5e
Submitter: "Zuul (22348)"
Branch: stable/train

commit 5d6faee55fdf110d6561e23ec13f3753b493dc5e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Sep 23 16:35:45 2020 +0000

    Reduce log level in "ensure_device_is_ready"

    If the device is not ready, the method should inform about this
    event. The code calling this method, if needed, can write a higher
    log message.

    Change-Id: Ib7c5ba736f6e4ccc88df665faeef304c176a24e7
    Closes-Bug: #1896920
    (cherry picked from commit b1f1c8aa50012d09b7a81abfb99d02e0c457fc8c)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 17.3.0

This issue was fixed in the openstack/neutron 17.3.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers