port update api should not lose foreign external_ids

[Flavio Fernandes]

Currently, the update_port api in networking_ovn does not seem to
retain values in the external_ids that it may not know about.

That is not proper behavior as external ids in the lsp may be
storing data used by another entity in neutron, such as
ovn-octavia-provider.

Pseudo example:

1- create neutron port (which creates lsp in ovn)
2- add a new value to lsp's external_ids
3- invoke neutron: port_update
4- check an verify that after port update the key/value pair added in step 2 is still present

Ref code to networking-ovn port_update:

https://github.com/openstack/networking-ovn/blob/51e4351309c1f38c2ed353e6547c60ae9d5d50f5/networking_ovn/common/ovn_client.py#L456

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/victoria
Review: https://review.opendev.org/755081

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/755082

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/753833
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=be3669258cb6f8a6c43b2f016a344185075fa544
Submitter: Zuul
Branch: master

commit be3669258cb6f8a6c43b2f016a344185075fa544
Author: Flavio Fernandes <email address hidden>
Date: Wed Sep 23 15:28:55 2020 -0400

    [OVN] update_port should not remove values from external_ids

    Prior to this patch, the OVNClient implementation for neutron's
    update_port was setting the external_ids of the affected logical
    switch port to a hard-coded dictionary. This meant that any key
    value pairs that were not listed there would simply get removed.
    This would make it impossible for any other users of the
    external_id to have a reliable way of storing its data. One of
    such users could be the ovn-octavia-provider.

    Closes-Bug: #1896827
    Change-Id: Ie580534e4d91f1ca2e1dc8331632d49d4720e7ba

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755081
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f25f05959a43b09a02adef45f8bfe654941a0a27
Submitter: Zuul
Branch: stable/victoria

commit f25f05959a43b09a02adef45f8bfe654941a0a27
Author: Flavio Fernandes <email address hidden>
Date: Wed Sep 23 15:28:55 2020 -0400

    [OVN] update_port should not remove values from external_ids

    Prior to this patch, the OVNClient implementation for neutron's
    update_port was setting the external_ids of the affected logical
    switch port to a hard-coded dictionary. This meant that any key
    value pairs that were not listed there would simply get removed.
    This would make it impossible for any other users of the
    external_id to have a reliable way of storing its data. One of
    such users could be the ovn-octavia-provider.

    Closes-Bug: #1896827
    Change-Id: Ie580534e4d91f1ca2e1dc8331632d49d4720e7ba
    (cherry picked from commit be3669258cb6f8a6c43b2f016a344185075fa544)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/755082
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=58e2def05f5e444e900a5dc03b6ef6b3cb3f5325
Submitter: Zuul
Branch: stable/ussuri

commit 58e2def05f5e444e900a5dc03b6ef6b3cb3f5325
Author: Flavio Fernandes <email address hidden>
Date: Wed Sep 23 15:28:55 2020 -0400

    [OVN] update_port should not remove values from external_ids

    Prior to this patch, the OVNClient implementation for neutron's
    update_port was setting the external_ids of the affected logical
    switch port to a hard-coded dictionary. This meant that any key
    value pairs that were not listed there would simply get removed.
    This would make it impossible for any other users of the
    external_id to have a reliable way of storing its data. One of
    such users could be the ovn-octavia-provider.

    Note: mock module does not exist in stable/victoria and master,
    thus the conflict below.

    Conflicts:
            neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_db_resources.py

    Closes-Bug: #1896827
    Change-Id: Ie580534e4d91f1ca2e1dc8331632d49d4720e7ba
    (cherry picked from commit be3669258cb6f8a6c43b2f016a344185075fa544)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.3.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 7.4.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 18.0.0.0rc1 release candidate.