[OVN] test_add_interface_in_use fail with OVN

[Lucas Alvares Gomes]

The test neutron-tempest-plugin test_add_interface_in_use fails when ml2/ovn is used.

Apparently this behavior is a consequence of this fix: https://review.opendev.org/#/c/724930, reverting the patch makes it work again BUT, reverting it will re-introduce the original bug that the patch fixed.

Basically what happens is that now the add_router_interface() method from ml2/ovn will never raise the PortInUse exception if you try to add the same interface twice. The test_add_interface_in_use is a negative test that validates this behavior.

This idempotent behavior was introduced because of the maintenance thread but I believe that we can make the API behave as expected (raising the PortInUse) and the maintenance code can handle this exception and ignore it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/752057

[OpenStack Infra (hudson-openstack)]

Change abandoned by Lucas Alvares Gomes (<email address hidden>) on branch: master
Review: https://review.opendev.org/752057
Reason: Wrong logic

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/752107

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752057
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f2643f27fb617a517be95138246331d8556c0cc3
Submitter: Zuul
Branch: master

commit f2643f27fb617a517be95138246331d8556c0cc3
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Sep 15 15:30:22 2020 +0100

    [OVN] Fix test_add_interface_in_use negative test

    While fixing https://bugs.launchpad.net/neutron/+bug/1876148 we've made
    the add_router_interface method idempotent and it no longer raised a
    Conflict if the same interface was added twice, this broke the
    test_add_interface_in_use from neutron-tempest-pluign.

    Change-Id: I76d46a4c3c8af166e022894a5693d5c78555ea50
    Closes-Bug: #1895671
    Signed-off-by: Lucas Alvares Gomes <email address hidden>

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/752107
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4fa690c1dd64ad1c49af60195def801a3dad9f69
Submitter: Zuul
Branch: stable/ussuri

commit 4fa690c1dd64ad1c49af60195def801a3dad9f69
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Sep 15 15:30:22 2020 +0100

    [OVN] Fix test_add_interface_in_use negative test

    While fixing https://bugs.launchpad.net/neutron/+bug/1876148 we've made
    the add_router_interface method idempotent and it no longer raised a
    Conflict if the same interface was added twice, this broke the
    test_add_interface_in_use from neutron-tempest-pluign.

    Change-Id: I76d46a4c3c8af166e022894a5693d5c78555ea50
    Closes-Bug: #1895671
    Signed-off-by: Lucas Alvares Gomes <email address hidden>
    (cherry picked from Neutron commit f2643f27fb617a517be95138246331d8556c0cc3)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/networking-ovn 7.4.0 release.