Neutron server logs are too big in the gate jobs

Bug #1892017 reported by Slawek Kaplonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Slawek Kaplonski

Bug Description

As per email http://lists.openstack.org/pipermail/openstack-discuss/2020-August/016579.html we should not log all time-cost entries in the server logs for every job.
Maybe we can do it only in the rally based jobs and disable it everywhere else?

Tags: gate-failure
Revision history for this message
LIU Yulong (dragon889) wrote :

According to the mail, this https://review.opendev.org/#/c/730879/ should be reverted.

Revision history for this message
LIU Yulong (dragon889) wrote :

IMO, there are tons of resource extend calls during API/RPC request.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.opendev.org/746714

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.opendev.org/746714
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=024b5af64b69a6fb9eab7c5764d8f2b91f17ec2f
Submitter: Zuul
Branch: master

commit 024b5af64b69a6fb9eab7c5764d8f2b91f17ec2f
Author: Slawek Kaplonski <email address hidden>
Date: Tue Aug 18 15:13:36 2020 +0200

    Log time of the apply_func only if it took more than 0.1 second

    It seems that logging start and end time of the
    neutron_lib.db.resource_extend.apply_func function is little bit too
    much for e.g. our gate as neutron-server logs are huge in such case.

    So lets use directly oslo_utils.timeutils.time_it() function and log end
    of such calls only if it will take more than 0.1 seconds. If function
    was executed in shorter time, it isn't really necessary to have it
    logged.

    Change-Id: I3931c4f7cac4df72d71403ebcaa6ec0b83756640
    Closes-Bug: #1892017

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.