[ovn] Tempest test test_update_router_admin_state failing very often

[Slawek Kaplonski]

Test tempest.scenario.test_network_basic_ops.TestNetworkBasicOps.test_update_router_admin_state is failing (almost) 100% of times in the neutron-ovn-tempest-slow job.

Failure example: https://2e5a48e004c25d40a540-8aab0ff599dd9fcfda722d0dee6871dd.ssl.cf1.rackcdn.com/743832/1/check/neutron-ovn-tempest-slow/268b7cf/testr_results.html

Strack trace:

Traceback (most recent call last):
  File "/opt/stack/tempest/tempest/common/utils/__init__.py", line 89, in wrapper
    return f(*func_args, **func_kwargs)
  File "/opt/stack/tempest/tempest/scenario/test_network_basic_ops.py", line 566, in test_update_router_admin_state
    should_connect=True, msg="after updating "
  File "/opt/stack/tempest/tempest/scenario/test_network_basic_ops.py", line 213, in _check_public_network_connectivity
    message, server, mtu=mtu)
  File "/opt/stack/tempest/tempest/scenario/manager.py", line 723, in check_vm_connectivity
    msg=msg)
  File "/opt/stack/tempest/.tox/tempest/lib/python3.6/site-packages/unittest2/case.py", line 702, in assertTrue
    raise self.failureException(msg)
AssertionError: False is not true : Public network connectivity check failed. Reason: after updating admin_state_up of router to True
Timed out waiting for 172.24.5.234 to become reachable

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/791365
Committed: https://opendev.org/openstack/neutron/commit/4de350a54a3e3e59371391a7a022447b49ae508e
Submitter: "Zuul (22348)"
Branch: master

commit 4de350a54a3e3e59371391a7a022447b49ae508e
Author: Slawek Kaplonski <email address hidden>
Date: Fri May 14 08:31:32 2021 +0200

    Switch neutron-rally-task job to ML2/OVS and skip "test_models_sync"

    After switch of the default Neutron backend to the ML2/OVN
    in the Devstack we had 2 rally jobs running actually with the
    same Neutron backend.

    This patch configures explicitly ML2/OVS as a backend in the
    'neutron-rally-task' job so it is like it was before the change in
    the Devstack repo.

    In order to fix the CI, this patch also skips "test_models_sync" test
    cases. Once [1] is fixed and released, we'll be able to create SQL
    tables specifying the "_constraints_included" flag. When creating a
    table, this flag should be set to "False" in order to be able to set
    the "index" and "unique" parameters for each column in the table
    definition, as we do now.

    "test_update_router_admin_state" is excluded from
    "neutron-ovn-tempest-slow" until LP#1890445 is fixed.

    Set "test_restart_wsgi_on_sighup_multiple_workers" as unstable.

    CI job "neutron-ovn-tempest-slow" has been set to non-voting until
    LP#1930402 is fixed.

    Related-Bug: #1929518
    Related-Bug: #1890445
    Related-Bug: #1930402
    Related-Bug: #1930367

    [1]https://github.com/sqlalchemy/alembic/issues/848

    Change-Id: I38ed7931169434fecbbefa3762f51a522ef3c509

[Slawek Kaplonski (slaweq)]

I don't think this is still an issue. I don't see it in the gate currently so I'm closing that bug.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/830812

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/c/openstack/neutron/+/830812
Committed: https://opendev.org/openstack/neutron/commit/ce10c5189a2f3910acbba074885f961fce81b43b
Submitter: "Zuul (22348)"
Branch: master

commit ce10c5189a2f3910acbba074885f961fce81b43b
Author: yatinkarel <email address hidden>
Date: Thu Feb 24 18:08:36 2022 +0530

    Re enable update_router_admin_state scenario test

    The test is running fine now, let's get it running
    again in ovn-slow job which runs in periodic pipeline.

    Related-Bug: #1890445
    Change-Id: I45e09827e0b998fd3d05d5a8e9cbe24aff9f12e8