Validate subnet when plugging to the router don't works when plugging port

[Slawek Kaplonski]

Patch https://review.opendev.org/#/c/136733/ introduced validation of the subnets when it's plugged to the router so e.g. IPv6 subnet which is expected to get RAs from external router can't be plugged to the neutron router.
But this validation don't works when port is plugged to the router. And in that way such subnet with ipv6_ra_mode=None can be plugged to the Neutron router.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/744123

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744123
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=38c7fd7cef42e8c1e6430feb5ac01396c65560c2
Submitter: Zuul
Branch: master

commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/744830

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/744831

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/744832

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/744833

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/744834

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744830
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=34965644880aa7f3e48266f3e757da03cb423374
Submitter: Zuul
Branch: stable/ussuri

commit 34965644880aa7f3e48266f3e757da03cb423374
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619
    (cherry picked from commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744831
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f65abc251b8559d396320b96a61ceadf3181e69b
Submitter: Zuul
Branch: stable/train

commit f65abc251b8559d396320b96a61ceadf3181e69b
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619
    (cherry picked from commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744832
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c2311465bfa662779eb193f037bc77c21fdc1667
Submitter: Zuul
Branch: stable/stein

commit c2311465bfa662779eb193f037bc77c21fdc1667
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619
    (cherry picked from commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744834
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=77ce09bcef826f81f1bd1ae0c8b55b4ea36e3ec3
Submitter: Zuul
Branch: stable/queens

commit 77ce09bcef826f81f1bd1ae0c8b55b4ea36e3ec3
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Conflicts:
        neutron/db/l3_db.py

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619
    (cherry picked from commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/744833
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=b17f4ffeba6448e99cbedca5875d758a070e0dab
Submitter: Zuul
Branch: stable/rocky

commit b17f4ffeba6448e99cbedca5875d758a070e0dab
Author: Slawek Kaplonski <email address hidden>
Date: Fri Jul 31 12:50:16 2020 +0200

    Fix validation of IPv6 subnets with external RAs

    In case when such subnet is added directly to the router, there was
    validation and subnet which is expected to get RA messages from the
    external router couldn't be added to the Neutron router.

    But in case when port was first created manually and then plugged to the
    router, there wasn't such validation. This patch fixes it by adding same
    validation to adding router interface by port.

    Change-Id: I054296c790b697198550acbeae29546758b422c2
    Closes-Bug: #1889619
    (cherry picked from commit 38c7fd7cef42e8c1e6430feb5ac01396c65560c2)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron queens-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron rocky-eol release.