Change the default value of "propagate_uplink_status" to True

Bug #1888487 reported by Rodolfo Alonso on 2020-07-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Wishlist
Rodolfo Alonso

Bug Description

RFE [1] implemented a new port extension for SR-IOV ports. When this extension is enabled, the user can set this new flag "propagate_uplink_status" to True. That will set the VF link-state associated to this SR-IOV to "auto".

By default, without this extension, the link-state will be set to "enable" or "disable".

With this extension and "propagate_uplink_status" to False, the behavior will be the same ("enable"/"disable").

This bug is proposing to, by default, if this extension is enabled, to set "propagate_uplink_status" to True. That will set the link-state of the VF to "auto". That means the VF state will follow the PF state

NOTE: in some devices, the VF set to "enable" can transmit traffic when the PF is "down". That means if the VF is set to "auto", the VF won't be able to transmit. But, IMO, this behavior is more reasonable that allowing the VF to use the line when the PF is down.

[1]https://bugs.launchpad.net/neutron/+bug/1722720

Changed in neutron:
importance: Undecided → Wishlist
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
Slawek Kaplonski (slaweq) wrote :

Lets treat this as new RFE and discuss on the drivers team meeting.

tags: added: rfe-triaged
Slawek Kaplonski (slaweq) wrote :

This RFE was discussed and approved on today's drivers meeting. Thx for the proposal.

tags: added: api rfe-approved
removed: rfe-triaged

Fix proposed to branch: master
Review: https://review.opendev.org/744210

Changed in neutron:
status: New → In Progress

Reviewed: https://review.opendev.org/744208
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=1f06863e2b906ea5f12620ad1ba49719b2d97f7e
Submitter: Zuul
Branch: master

commit 1f06863e2b906ea5f12620ad1ba49719b2d97f7e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Jul 31 15:58:20 2020 +0000

    Change "propagate_uplink_status" default value to True

    The API extension ``uplink-status-propagation`` has changed the default
    value of ``propagate_uplink_status`` from False to True. Now, when this
    extension is enabled, the VF link state will be set, by default, to
    "auto", following the PF link state.

    Change-Id: I594198741d0ff9df71b5c0053387d229c66154c1
    Partial-Bug: #1888487

Reviewed: https://review.opendev.org/744210
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d4ae3f75a542112c92130828f992eec17d5bf0ba
Submitter: Zuul
Branch: master

commit d4ae3f75a542112c92130828f992eec17d5bf0ba
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Jul 31 15:33:47 2020 +0000

    Change "propagate_uplink_status" default value to True

    When "uplink-status-propagation" extension is enabled, new ports
    created will default the value of "propagate_uplink_status" to True.

    Closes-Bug: #1888487

    Change-Id: If1e533a61aeebbb4761d669c516fe86a4381765c

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers