neutron

String to byte conversion should provide the encoding type

Bug #1887385 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rodolfo Alonso

Bug Description

In [1], in case self.port is a string, the encoding method should be provided.

[1]https://github.com/openstack/neutron/blob/73557abefcba1c6ce0cef709d1082674c0217485/neutron/tests/functional/test_server.py#L231

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/740693

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Lajos Katona (lajos-katona)
tags: added: trivial
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/740693
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7a56b8f3bc5187846ce9f62dd9347ab5ffefcb5c
Submitter: Zuul
Branch: master

commit 7a56b8f3bc5187846ce9f62dd9347ab5ffefcb5c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 13 13:25:33 2020 +0000

    String to byte conversion should provide the encoding type

    Change-Id: Id988cab87d32d5721cd91152df194fbb6fa703c5
    Closes-Bug: #1887385

Changed in neutron:
status: In Progress → Fix Released
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/ussuri)

Fix proposed to branch: stable/ussuri
Review: https://review.opendev.org/744216

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/744218

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/ussuri)

Reviewed: https://review.opendev.org/744216
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=18f019984a71a0e09530c2e6ec29c010968de90e
Submitter: Zuul
Branch: stable/ussuri

commit 18f019984a71a0e09530c2e6ec29c010968de90e
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 13 13:25:33 2020 +0000

    String to byte conversion should provide the encoding type

    Change-Id: Id988cab87d32d5721cd91152df194fbb6fa703c5
    Closes-Bug: #1887385
    (cherry picked from commit 7a56b8f3bc5187846ce9f62dd9347ab5ffefcb5c)

tags: added: in-stable-ussuri
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/744218
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0090884e15068a69f229044e37847ae13432c970
Submitter: Zuul
Branch: stable/train

commit 0090884e15068a69f229044e37847ae13432c970
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 13 13:25:33 2020 +0000

    String to byte conversion should provide the encoding type

    Note:
    In Train we still need to support Python 2.7 so this commit
    adds import of six and six is used to make correct convertion
    to bytes in both Python 2.7 and Python 3.

    Change-Id: Id988cab87d32d5721cd91152df194fbb6fa703c5
    Closes-Bug: #1887385
    (cherry picked from commit 7a56b8f3bc5187846ce9f62dd9347ab5ffefcb5c)
    (cherry picked from commit 18f019984a71a0e09530c2e6ec29c010968de90e)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/749374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/749374
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0b1fd4fc2653a851f147c435e65c6f3a29781100
Submitter: Zuul
Branch: stable/stein

commit 0b1fd4fc2653a851f147c435e65c6f3a29781100
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Mon Jul 13 13:25:33 2020 +0000

    String to byte conversion should provide the encoding type

    Note:
    In Train we still need to support Python 2.7 so this commit
    adds import of six and six is used to make correct convertion
    to bytes in both Python 2.7 and Python 3.

    Change-Id: Id988cab87d32d5721cd91152df194fbb6fa703c5
    Closes-Bug: #1887385
    (cherry picked from commit 7a56b8f3bc5187846ce9f62dd9347ab5ffefcb5c)
    (cherry picked from commit 18f019984a71a0e09530c2e6ec29c010968de90e)
    (cherry picked from commit 0090884e15068a69f229044e37847ae13432c970)

tags: added: in-stable-stein
Dan Radez (dradez)
tags: removed: neutron-proactive-backport-potential
Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Bernard Cafarelli (bcafarel)
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.