not ensure default security group exists when filter by project_id

Bug #1875849 reported by ZhouHeng
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
ZhouHeng

Bug Description

when we filter security groups by 'tenant_id', neutron will ensure this project has default security group.
when we filter by 'project_id', neutron not ensure this project has default security group.
if it is new project, filter by 'tenant_id' will return one security group. filter by 'project_id' will return empty list.

Tags: api sg-fw
Changed in neutron:
assignee: nobody → ZhouHeng (zhouhenglc)
status: New → In Progress
ZhouHeng (zhouhenglc)
description: updated
Changed in neutron:
importance: Undecided → Medium
Akihiro Motoki (amotoki)
tags: added: api sg-fw
removed: api-ref
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

Hello Zhou:

Just one question: do you have [1] in your code? That was merged 9 weeks ago and cherry-picked to stable branches, but maybe you still don't have it. I think this is what you need.

Regards!

[1] https://review.opendev.org/#/c/709070/2/neutron/db/securitygroups_db.py

Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

I don't know why, gerrit is not updating the bug.

Fix proposed to branch: master
Review: https://review.opendev.org/#/c/724264

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/724264
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=76fa308ca9c45405657432c2ade83009dcbc9aa1
Submitter: Zuul
Branch: master

commit 76fa308ca9c45405657432c2ade83009dcbc9aa1
Author: zhouhenglc <email address hidden>
Date: Wed Apr 29 17:11:37 2020 +0800

    ensure default security group exists when filter by project_id

    now filter security groups by tenant_id, will auto ensure default security
    group, but project_id not. tenant_id is deprecated, we are used to filtering
    by project_id.

    Closes-bug: #1875849

    Change-Id: I3f1a2698768e2d66811bb290a892a1b089dff4ed

Changed in neutron:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.