The "old" parameter passed to the handle_ha_chassis_group_changes() method is a delta object and sometimes it does not contain the "external_ids" column (because it hasn't changed).
The absence of the "external_ids" column lead to the method into believe that the "old" object was no longer a gateway chassis (because since the external_ids column wasn't present, the code from is_gateway_chassis() returned False) and that triggered some changes in the default HA group which the external ports lives.
The combination of the agents health check (that triggers updates to the chassis) plus this problem with the absence of the "external_ids" column in the old object for certain updates is resulting in the SRIOV (external in OVN) ports to flap between the gateway chassis.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit ea999564a5b80dc
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Mar 27 15:23:49 2020 +0000
[OVN] HA Chassis Group: Ignore UPDATES when external_ids hasn't changed
The "old" parameter passed to the handle_
method is a delta object and sometimes it does not contain the
"external_ids" column (because it hasn't changed).
The absence of that column was misleading that method into believe that
the "old" object was no longer a gateway chassis and that triggered some
changes in the HA group. Changing the HA group resulted in the SRIOV
(external in OVN) ports to start flapping between the gateway chassis.
This patch is adding a check to verify that the "external_ids" column
has changed before acting on it, otherwise just ignore the update and
return.
Closes-Bug: #1869389
Change-Id: I3f7de633e5546d
Signed-off-by: Lucas Alvares Gomes <email address hidden>