"ncat" rootwrap filter is missing

[Rodolfo Alonso]

"ncat" rootwrap filter is missing, as we can see in [1].

Log:
RuntimeError: Process ['ncat', '0.0.0.0', '1234', '-l', '-k'] hasn't been spawned in 20 seconds. Return code: 99, stdout: , sdterr: /home/zuul/src/opendev.org/openstack/neutron/.tox/dsvm-functional/bin/neutron-rootwrap: Unauthorized command: ip netns exec nc-2aefd97b-cf51-4404-804b-b61dc17ce59f ncat 0.0.0.0 1234 -l -k (no filter matched)

[1] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b89/701733/28/check/neutron-functional/b89805d/testr_results.html

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/707368

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Yes, we need to backport this patch to S and T: https://review.opendev.org/#/q/If8cf47a01dc353734ad07ca6cd4db7bec6c90fb6

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707368
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0ef4233d891f8fa42a073901051bf0310f61eebb
Submitter: Zuul
Branch: master

commit 0ef4233d891f8fa42a073901051bf0310f61eebb
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Feb 12 11:43:27 2020 +0000

    Add "ncat" rootwrap filter for debug

    In [1], new tests to check "ncat" tool were added. The missing piece
    of this patch was to add a new rootwrap filter to allow to execute
    "ncat" binary as root and inside a namespace.

    Closes-Bug: #1862927

    [1]https://review.opendev.org/#/q/If8cf47a01dc353734ad07ca6cd4db7bec6c90fb6

    Change-Id: I8e8e5cd8c4027cce58c7073002120d14f251463d

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/707697

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707697
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2dd62221984d39be355a4fdfe667053153aa60d4
Submitter: Zuul
Branch: master

commit 2dd62221984d39be355a4fdfe667053153aa60d4
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Feb 13 17:07:06 2020 +0000

    Set an absolute path in rootwrap filters_path

    If a relative path is set in rootwrap filters_path, the rootwrap
    command must be executed from the neutron root directory. Some
    commands, like those execute by RootHelperProcess, do not have
    a defined working directory. To avoid the problems present in the
    related bug, an absolute path is set in the rootwrap configuration.

    Related-Bug: #1862927

    Change-Id: I02ce4d6b84242c42ec26954eeb9b776cb779bff4

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello:

The CI is still failing with [1] but now with another problem: http://paste.openstack.org/show/789579/

It seems that, in some rare occasions, the filter files under the "filters_path" directory are not present.

Because those tests are not very relevant (those tests are testing test tools) and in sake of stabilizing the CI, I'll mark them as unstable.

Regards.

[1]https://review.opendev.org/707697
[2]https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_d22/701733/37/gate/neutron-functional/d2242b7/testr_results.html

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/707844

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707786
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=22ce84ab4d5b12348a58fd82828c4eacb04fd578
Submitter: Zuul
Branch: master

commit 22ce84ab4d5b12348a58fd82828c4eacb04fd578
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Feb 14 08:57:07 2020 +0000

    Revert "Add "ncat" rootwrap filter for debug"

    This reverts commit 0ef4233d891f8fa42a073901051bf0310f61eebb.

    This patch is introducing a redundant filter already present in
    "testing.filters". The problem described in the related bug should
    be solved in https://review.opendev.org/#/c/707697/.

    Related-Bug: #1862927
    Related-Bug: #1863213

    Change-Id: I4de37364a6fb0184230a9742daced40e4edbfb30

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/707844
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=98266664c85a1f403153e9a72786cec436a7754a
Submitter: Zuul
Branch: master

commit 98266664c85a1f403153e9a72786cec436a7754a
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Feb 14 14:08:52 2020 +0000

    Mark NetcatTesterTestCase tests as unstable

    As commented in the bug, sometimes rootwrap does not find the filter
    files defined in "filters_path" configuration option. This leads to
    an error during the execution of the bash command.

    Change-Id: I1df041e050fe4de37476e13031f697334b82a967
    Related-Bug: #1862927

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.