[OVN] Mechanism driver - failing to recreate floating IP

[Maciej Jozefczyk]

We observe on gates ERROR logs like:

Please investigate.

Jan 31 12:43:54.475677 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: DEBUG neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance [None req-1b9ba8f3-8770-44b1-a398-c75e1fe7c0a4 None None] Maintenance task: Fixing resource
c9a56d17-e82a-4758-87b6-afb6af68ab22 (type: floatingips) at create/update {{(pid=378) check_for_inconsistencies /opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py:286}}
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance [None req-1b9ba8f3-8770-44b1-a398-c75e1fe7c0a4 None None] Maintenance task: Failed to fix re
source c9a56d17-e82a-4758-87b6-afb6af68ab22 (type: floatingips): TypeError: create_floatingip() missing 1 required positional argument: 'floatingip'
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance Traceback (most recent call last):
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py"
, line 297, in check_for_inconsistencies
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance self._fix_create_update(admin_context, row)
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance File "/opt/stack/neutron/neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py"
, line 158, in _fix_create_update
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance res_map['ovn_create'](n_obj)
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance TypeError: create_floatingip() missing 1 required positional argument: 'floatingip'
Jan 31 12:43:54.542343 ubuntu-bionic-rax-ord-0014258431 neutron-server[32458]: ERROR neutron.plugins.ml2.drivers.ovn.mech_driver.ovsdb.maintenance

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/706152

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/706152
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ee73b5061813b49bf0cd6aa782848796acbf484b
Submitter: Zuul
Branch: master

commit ee73b5061813b49bf0cd6aa782848796acbf484b
Author: Brian Haley <email address hidden>
Date: Wed Feb 5 17:56:51 2020 -0500

    [OVN] Call OVNClient methods with context when possible

    The OVN maintenance code was not always calling into
    the OVNClient class methods with the correct number of
    arguments, leading to exceptions.

    After a deeper review, there were a number of places
    where this was happening, so changed most methods to
    take a 'context' argument since it's usually available
    in the caller.

    Change-Id: I1bcb0ca68747e4c32523e41307dc132291c55f6d
    Closes-bug: #1861502