[OVS] OVS agent should not plug/unplug smartNIC ports

[Rodolfo Alonso]

Related to https://bugs.launchpad.net/neutron/+bug/1785608

OVS agent should not deal with L1 operations (port plug/unplug). Those operations should be done by os-vif. The logic implemented in [1] should belongs to os-vif/vif_plug_ovs.

[1] https://review.opendev.org/#/c/586252/46/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py

[Lajos Katona (lajos-katona)]

isn't this one related to https://review.opendev.org/702806 ?

[Lajos Katona (lajos-katona)]

I set it to whislist as no functional problem is seen now, it is a design flaw which should be fixed to keep neutron design integrity, as I see.
Perhaps a possible drivers-meeting topic?

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello Lajos:

No, this patch [1] is doing the opposite: is calling plug/unplug from the OVS agent. And I'm also talking about [2]. This patch introduced the method "treat_smartnic_port" to make the L1 operations from the OVS itself. The OVS agent is the agent of the Open vSwitch ML2 plugin and thus should take care of L2 (and L3/L4) operations, not L1.

[1] https://review.opendev.org/702806
[2] https://review.opendev.org/#/c/586252/

[Slawek Kaplonski (slaweq)]

Rodolfo, do You think we should revert https://review.opendev.org/#/c/586252/ now and move this to os-vif?