[neutron-dynamic-routing]The bgp_speaker_show_dragents interface should be modified to bgp_dragent_list_hosting_speakers

Bug #1858377 reported by zhanghao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Invalid
Undecided
Unassigned
python-neutronclient
Fix Released
Wishlist
zhanghao

Bug Description

As described in [1], [2]
List BGP speakers hosted by a Dynamic Routing Agent
/v2.0/agents/<bgp-dragent-id>/bgp-drinstances
neutronclient:neutron bgp-speaker-list-on-dragent XXX

List Dynamic Routing Agents hosting a specific BGP Speaker
/v2.0/bgp-speakers/<bgp-speaker-id>/bgp-dragents
neutronclient:neutron bgp-dragent-list-hosting-speaker XXX

Corresponding in openstackclient
List BGP speakers hosted by a Dynamic Routing Agent
openstack bgp speaker list --agent XXX

List Dynamic Routing Agents hosting a specific BGP Speaker
openstack bgp speaker show dragents XXX

I think it is more appropriate to replace 'bgp_speaker_show_dragents'
with 'bgp_dragent_list_hosting_speakers'.

[1] https://docs.openstack.org/neutron-dynamic-routing/latest/reference/index.html#rest-interface
[2] https://docs.openstack.org/newton/networking-guide/config-bgp-dynamic-routing.html

Revision history for this message
Slawek Kaplonski (slaweq) wrote :

Hi,

IIUC Your bug report, You want to change command in python-openstackclient. Is that correct?
If so, You should open a bug for openstackclient and this project uses storyboard already: https://storyboard.openstack.org/#!/project/975

Revision history for this message
Dr. Jens Harbott (j-harbott) wrote :

Actually this is a command implemented by the python-neutronclient OSC plugin. There's a patch proposed at https://review.opendev.org/701125

Changed in python-neutronclient:
status: New → In Progress
Changed in neutron:
status: New → Invalid
Akihiro Motoki (amotoki)
Changed in python-neutronclient:
importance: Undecided → Wishlist
Changed in python-neutronclient:
assignee: nobody → zhanghao (zhanghao2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-neutronclient (master)

Reviewed: https://review.opendev.org/701125
Committed: https://git.openstack.org/cgit/openstack/python-neutronclient/commit/?id=bb5b9cac6e0fd65bd620d514d29751800575d5cc
Submitter: Zuul
Branch: master

commit bb5b9cac6e0fd65bd620d514d29751800575d5cc
Author: zhanghao <email address hidden>
Date: Mon Jan 6 05:33:53 2020 -0500

    Replace 'bgp speaker show dragents' with 'bgp dragent list'

    In order to follow other agent related commands in OSC, it is more
    appropriate and friendly to replace 'bgp speaker show dragents' with
    'bgp dragent list'. this patch uses 'openstack bgp dragent list' to
    show the list of dragents, and the optional parameter 'bgp-speaker'
    shows the list of dragents hosting a specific bgp speaker.

    Change-Id: I9e0703fccf535b1e1a2055ed917336055b7395f5
    Closes-Bug: #1858377

Changed in python-neutronclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-neutronclient 7.1.0

This issue was fixed in the openstack/python-neutronclient 7.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.