Constraints file is not considered during doc build

[Lajos Katona]

During doc build constraints file is not considered, which actually causes that stable/stein docs job is failing since neutron-lib 1.30.0 is released.

The traceback:
2019-12-11 13:17:24.407556 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/neutron/neutron/tests/functional/db/test_migrations.py", line 34, in <module>
2019-12-11 13:17:24.407622 | ubuntu-bionic | from neutron.db.migration.models import head as head_models
2019-12-11 13:17:24.407718 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/neutron/neutron/db/migration/models/head.py", line 29, in <module>
2019-12-11 13:17:24.407770 | ubuntu-bionic | from neutron.db import agentschedulers_db # noqa
2019-12-11 13:17:24.407883 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/neutron/neutron/db/agentschedulers_db.py", line 47, in <module>
2019-12-11 13:17:24.407941 | ubuntu-bionic | class AgentSchedulerDbMixin(agents_db.AgentDbMixin):
2019-12-11 13:17:24.408050 | ubuntu-bionic | File "/home/zuul/src/opendev.org/openstack/neutron/neutron/db/agentschedulers_db.py", line 55, in AgentSchedulerDbMixin
2019-12-11 13:17:24.408095 | ubuntu-bionic | constants.AGENT_TYPE_LOADBALANCER: None,
2019-12-11 13:17:24.408181 | ubuntu-bionic | AttributeError: module 'neutron_lib.constants' has no attribute 'AGENT_TYPE_LOADBALANCER'

The issue presents on master as well.

[Slawek Kaplonski (slaweq)]

should we use neutron-lib 1.30 in stein release? I don't think so

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/698692

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/698708

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698692
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=07be7934359aa121761396ba47128904f19cb2e4
Submitter: Zuul
Branch: master

commit 07be7934359aa121761396ba47128904f19cb2e4
Author: Elod Illes <email address hidden>
Date: Thu Dec 12 11:14:10 2019 +0100

    Use constraints for docs tox target

    In Stein the docs target started to fail when new release of
    neutron-lib appeared. This is because tox installs neutron and its
    requirements without any constraints. To fix this both the upper
    constraints and neutron requirements needs to be added to dependencies
    of docs target.

    Closes-Bug: #1856156
    Change-Id: Iea61238f37fdf24c0264f96d104ee0b3b6aec8e2

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/699969

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698708
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d1c4ba581085f4978da82a597b1387d60e79ff0c
Submitter: Zuul
Branch: stable/train

commit d1c4ba581085f4978da82a597b1387d60e79ff0c
Author: Elod Illes <email address hidden>
Date: Thu Dec 12 11:14:10 2019 +0100

    Use constraints for docs tox target

    In Stein the docs target started to fail when new release of
    neutron-lib appeared. This is because tox installs neutron and its
    requirements without any constraints. To fix this both the upper
    constraints and neutron requirements needs to be added to dependencies
    of docs target.

    Note: patch adjusted to stable/train

    Closes-Bug: #1856156
    Change-Id: Iea61238f37fdf24c0264f96d104ee0b3b6aec8e2
    (cherry picked from commit 07be7934359aa121761396ba47128904f19cb2e4)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/698565
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=34239888eb661415ed372808304a42339563dad6
Submitter: Zuul
Branch: stable/stein

commit 34239888eb661415ed372808304a42339563dad6
Author: Elod Illes <email address hidden>
Date: Thu Dec 12 11:14:10 2019 +0100

    Use constraints for docs tox target and cap hacking

    This patch fixes 3 problems to fix gate jobs in Stein.

    1. In Stein the docs target started to fail when new release of
       neutron-lib appeared. This is because tox installs neutron and its
       requirements without any constraints. To fix this both the upper
       constraints and neutron requirements needs to be added to
       dependencies of docs target.

    2. Patch adjusted to stable/stein and by using upper constraints in
       Stein another sphinx error comes up:

       ../config-services-agent.rst:70:Error in "code-block" directive:
       1 argument(s) required, 0 supplied.

       This also makes the docs build fail so a 'none' argument is added to
       the code-block.

    3. Cap hacking in test-requirements.txt

       hacking as a linter is in global requirements blacklist and so is
       not in constraints. Recent release introduced new rules that
       required fix on master, on stable branches we should rather cap to
       the version that was in use during this release development.

    Closes-Bug: #1856156
    Change-Id: Iea61238f37fdf24c0264f96d104ee0b3b6aec8e2
    (cherry picked from commit 07be7934359aa121761396ba47128904f19cb2e4)
    (cherry picked from commit d1c4ba581085f4978da82a597b1387d60e79ff0c)

[Elod Illes (elod-illes)]

In queens docs tox target uses the 'deps' from base 'testenv', which contains the necessary requirements files. The problem does not exist in Queens.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/699969
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ca63f48054d7e359c47ebd73541f114b1fcba6ba
Submitter: Zuul
Branch: stable/rocky

commit ca63f48054d7e359c47ebd73541f114b1fcba6ba
Author: Elod Illes <email address hidden>
Date: Thu Dec 12 11:14:10 2019 +0100

    Use constraints for docs tox target and cap hacking

    This patch fixes 3 problems to fix gate jobs in Rocky.

    1. In Stein the docs target started to fail when new release of
       neutron-lib appeared. This is because tox installs neutron and its
       requirements without any constraints. To fix this both the upper
       constraints and neutron requirements needs to be added to
       dependencies of docs target.

    2. Cap hacking in test-requirements.txt

       hacking as a linter is in global requirements blacklist and so is
       not in constraints. Recent release introduced new rules that
       required fix on master, on stable branches we should rather cap to
       the version that was in use during this release development.

    3. Update sphinx requirements

       Requirement check is failing on sphinx:

       Requirement(package='sphinx', location='', specifiers='!=1.6.6,>=1.6.2', markers='', comment='# BSD', extras=frozenset()) 'markers': '' does not match "python_version>='3.4'"
       Could not find a global requirements entry to match package {}. If the package is already included in the global list, the name or platform markers there may not match the local settings.

    Conflicts:
           tox.ini

    Closes-Bug: #1856156
    Change-Id: Iea61238f37fdf24c0264f96d104ee0b3b6aec8e2
    (cherry picked from commit 07be7934359aa121761396ba47128904f19cb2e4)
    (cherry picked from commit d1c4ba581085f4978da82a597b1387d60e79ff0c)
    (cherry picked from commit 34239888eb661415ed372808304a42339563dad6)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 15.0.2 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.7 release.