neutron

ovs-offload with vxlan is broken due to adding skb mark

Bug #1855888 reported by Moshe Levi
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
neutron
Fix Released
High
Moshe Levi

Bug Description

The following patch [1] add use of egress_pkt_mark which is not support with ovs hardware offload.
This cause regression break in openstack when using ovs hardware offload when using vxlan

[1] - https://review.opendev.org/#/c/675054/

Revision history for this message
Moshe Levi (moshele) wrote :

from information of ovs hardware offload see [1]

[1] -https://github.com/openstack/neutron/blob/master/doc/source/admin/config-ovs-offload.rst

OpenStack Infra (hudson-openstack)
Changed in neutron:
assignee: nobody → Moshe Levi (moshele)
status: New → In Progress
Slawek Kaplonski (slaweq)
Changed in neutron:
importance: Undecided → High
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/698336

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Moshe Levi (<email address hidden>) on branch: master
Review: https://review.opendev.org/698234
Reason: abandon the revert in favor of this https://review.opendev.org/#/c/698336/

YAMAMOTO Takashi (yamamoto)
tags: added: ovs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/698336
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a75ec08ddb6a672ba685a11ba3f7df1569497723
Submitter: Zuul
Branch: master

commit a75ec08ddb6a672ba685a11ba3f7df1569497723
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/699912

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/700055

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/700057

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/700059

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.opendev.org/700061

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/699912
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=a1237df19e677ab55754462e52ad346d340ed56c
Submitter: Zuul
Branch: stable/train

commit a1237df19e677ab55754462e52ad346d340ed56c
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
    (cherry picked from commit a75ec08ddb6a672ba685a11ba3f7df1569497723)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.opendev.org/700059
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=54e1a6b1bc378c0745afc03987d0fea241b826ae
Submitter: Zuul
Branch: stable/rocky

commit 54e1a6b1bc378c0745afc03987d0fea241b826ae
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Conflicts:
        neutron/agent/common/ovs_lib.py

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
    (cherry picked from commit a75ec08ddb6a672ba685a11ba3f7df1569497723)
    (cherry picked from commit bee5059ccb35e23d3c84ae8f959fa695f8cae931)

tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/700055
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bee5059ccb35e23d3c84ae8f959fa695f8cae931
Submitter: Zuul
Branch: stable/stein

commit bee5059ccb35e23d3c84ae8f959fa695f8cae931
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
    (cherry picked from commit a75ec08ddb6a672ba685a11ba3f7df1569497723)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.opendev.org/700061
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2723ba4b09ace22a82dbbf8fb01276ef68cd74ff
Submitter: Zuul
Branch: stable/pike

commit 2723ba4b09ace22a82dbbf8fb01276ef68cd74ff
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Conflicts:
        neutron/agent/common/ovs_lib.py
        neutron/tests/unit/agent/common/test_ovs_lib.py

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
    (cherry picked from commit a75ec08ddb6a672ba685a11ba3f7df1569497723)
    (cherry picked from commit bee5059ccb35e23d3c84ae8f959fa695f8cae931)
    (cherry picked from commit 169b4baa6f9a43ab3996f27051c0ae01ee854193)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.opendev.org/700057
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=49e35bc4ba5c65ecfe1044fc21fcd8cb3d0346c3
Submitter: Zuul
Branch: stable/queens

commit 49e35bc4ba5c65ecfe1044fc21fcd8cb3d0346c3
Author: Moshe Levi <email address hidden>
Date: Tue Dec 10 23:11:54 2019 +0200

    don't clear skb mark when ovs is hw-offload enabled

    skb mark is not supported when using ovs hw-offload and using it
    breaks the vxlan offload.

    This patch clear skb mark only if ovs hw-offload is disabled.
    This should be fine as ovs with hw-offload runs on the
    compute node (DVR is not supported), so clear the skb mark for
    the qrouter is not needed.

    Closes-Bug: #1855888

    Conflicts:
        neutron/agent/common/ovs_lib.py

    Change-Id: I71f45fcd9b7e7bdacaafc7fa96c775e88333ab48
    (cherry picked from commit a75ec08ddb6a672ba685a11ba3f7df1569497723)
    (cherry picked from commit bee5059ccb35e23d3c84ae8f959fa695f8cae931)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.0.2

This issue was fixed in the openstack/neutron 15.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.1.0

This issue was fixed in the openstack/neutron 14.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.0.0.0b1

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.7

This issue was fixed in the openstack/neutron 13.0.7 release.

Bernard Cafarelli (bcafarel)
tags: added: neutron-proactive-backport-potential
Slawek Kaplonski (slaweq)
tags: removed: neutron-proactive-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron pike-eol

This issue was fixed in the openstack/neutron pike-eol release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron queens-eol

This issue was fixed in the openstack/neutron queens-eol release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.