SmartNIC OVS representor port is not removed from OVS on instance tear down

[Hamdy Khader]

Openstack: Train

After BM instance is deleted, OVS on the SmartNIC still has the port "pf1hpf" that should be removed.

 Bridge br-int
        Controller "tcp:127.0.0.1:6633"
            is_connected: true
        fail_mode: secure
        Port br-int
            Interface br-int
                type: internal
        Port int-br-ex
            Interface int-br-ex
                type: patch
                options: {peer=phy-br-ex}
        Port "pf1hpf"
            tag: 4095
            Interface "pf1hpf"
        Port int-br-infra
            Interface int-br-infra
                type: patch
                options: {peer=phy-br-infra}
        Port int-br-sriov
            Interface int-br-sriov
                type: patch
                options: {peer=phy-br-sriov}

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697450

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/697473

[OpenStack Infra (hudson-openstack)]

Change abandoned by Hamdy Khader (<email address hidden>) on branch: master
Review: https://review.opendev.org/697473
Reason: Will review the fix and push again.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/702806
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=512d8abb4b063bbfcdb0711b18e0157b668617f6
Submitter: Zuul
Branch: master

commit 512d8abb4b063bbfcdb0711b18e0157b668617f6
Author: waleed mousa <email address hidden>
Date: Mon Feb 24 08:52:29 2020 +0000

    Neutron ovs agent: Removing SmartNIC OVS representor port on instance tear down and resync

    The current flow where a port is unbound from an agent running on
    smartnic was not implemented causing representor ports to remain
    connected to the integration bridge.
    This change solves this issue in two cases:
      * When deleting the instance and so deleting SmartNic port,
        it will remove the unbound ports from integration bridge
      * When resync SmartNic ports on Neutron OVS agent restart,
        it will remove the port from integration bridge not mapped to
        neutron SmartNic ports.

    Closes-Bug: #1855260
    Change-Id: I7077577cca54329fbcb77fbde730389835ab6497

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/train
Review: https://review.opendev.org/717149

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/717149
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c09f191419b71cd1f414ea70dd47358b49d3c390
Submitter: Zuul
Branch: stable/train

commit c09f191419b71cd1f414ea70dd47358b49d3c390
Author: waleed mousa <email address hidden>
Date: Mon Feb 24 08:52:29 2020 +0000

    Neutron ovs agent: Removing SmartNIC OVS representor port on instance tear down and resync

    The current flow where a port is unbound from an agent running on
    smartnic was not implemented causing representor ports to remain
    connected to the integration bridge.
    This change solves this issue in two cases:
      * When deleting the instance and so deleting SmartNic port,
        it will remove the unbound ports from integration bridge
      * When resync SmartNic ports on Neutron OVS agent restart,
        it will remove the port from integration bridge not mapped to
        neutron SmartNic ports.

    Closes-Bug: #1855260
    Change-Id: I7077577cca54329fbcb77fbde730389835ab6497
    (cherry picked from commit 512d8abb4b063bbfcdb0711b18e0157b668617f6)

[OpenStack Infra (hudson-openstack)]

Change abandoned by "Rodolfo Alonso <email address hidden>" on branch: master
Review: https://review.opendev.org/c/openstack/neutron/+/697450
Reason: Superseded by https://review.opendev.org/c/openstack/neutron/+/702806/