neutron

DhcpLocalProcess "_enable" method should not call "restart" --> "enable"

Bug #1854940 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Rodolfo Alonso

Bug Description

DhcpLocalProcess "DhcpLocalProcess._enable" method should not call "DhcpLocalProcess.restart", what is calling "DhcpLocalProcess.enable". This call chain will introduce a second active wait [1], that is unnecessary.

PS: IMO, this should be considered "importance = wishlist".

[1] https://github.com/openstack/neutron/blob/26526ba275ecbab5064fb7db9ae2ee2f286a83ca/neutron/agent/linux/dhcp.py#L217

See original description
Rodolfo Alonso (rodolfo-alonso-hernandez)
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
description: updated
Nate Johnston (nate-johnston)
Changed in neutron:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/697135

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/697135
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f758bc998096a8aa20201c95da7da74e07a60bb1
Submitter: Zuul
Branch: master

commit f758bc998096a8aa20201c95da7da74e07a60bb1
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Dec 3 14:56:32 2019 +0000

    DhcpLocalProcess._enable should not call DhcpLocalProcess.restart

    "DhcpLocalProcess._enable", instead of calling
    "DhcpLocalProcess.restart", should only stop the server and continue
    the method. This will avoid getting into a second active wait context.

    Change-Id: Id321430c344723363786ab48584b1b48ba69f679
    Closes-Bug: #1854940

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.0.0.0b1

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.