[RFE] ports do not inherit their associated network's policy

[Noy fridman]

Description:
Once attaching a port to a network that has QoS policy,
the policy is not inherited to the port.
Network policy should be used for all ports which don't have own policy
associated.

Steps to Reproduce:
1. Create new internal network
2. Create new QoS policy
3. Attach the policy to the network
4. create a new port
5. Attach the port to the network

Actual results:
The port has no policy associated
qos_policy_id is: None

Expected results:
The post should has the network associated QoS policy

Version: ROCKY

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello Noy:

The "port" field "qos_policy_id" refers only to the specific QoS policy assigned to this object. When the object is created/modified, the QoS core extension do NOT populated in the port dictionary the network QoS policy and thus this information is not passed to the SDK and the OSclient. That's why you can't see the port "network_qos_policy_id".

But this information is given to the agents (network backends: OVS, LB, etc) via RPC [1]. The port "qos_policy_id" and the "network_qos_policy_id" parameters are used to apply the correct policy for each port.

Since [2] and [3] we have the "network_qos_policy_id" in the DB object and the OVO. Now, we need to:
- Add this information in the "port" dictionary when returning the "Ml2Plugin._make_port_dict()" function.
- Add this new parameter to the port definition in OS SDK.
- Add this new parameter (as read only) in the "show" command for port in OSclient.

Regards.

[1] https://github.com/openstack/neutron/blob/master/neutron/agent/rpc.py#L362
[2] https://review.opendev.org/#/c/667981/
[3] https://review.opendev.org/#/c/667998/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/693234

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/693244

[Slawek Kaplonski (slaweq)]

We approved this rfe during the last driver meeting.
Please be aware that as this is API change, it should be discoverable so we need to add new API extension for that too.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693234
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=c5cb36903f878d8cd94d61fd5de2a06f7695e659
Submitter: Zuul
Branch: master

commit c5cb36903f878d8cd94d61fd5de2a06f7695e659
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Nov 6 17:56:46 2019 +0000

    Add "qos_network_policy_id" field to "port" definition

    DocImpact

    Change-Id: Ic1d555ef957124c866a2baf788564b3c200583eb
    Related-Bug: #1851362

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/701985

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/701985
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=9e71ff363fda908497240f76964e3f13adf07340
Submitter: Zuul
Branch: master

commit 9e71ff363fda908497240f76964e3f13adf07340
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Fri Jan 10 15:38:08 2020 +0000

    Fix new parameter added in "qos_port_network_policy" API

    The new parameter in "port" API should be "qos_network_policy_id",
    not "qos_policy_id", which already exists now.

    Change-Id: Ia9bc082b3fae0e3a762ec65a86c8d8c246dcf170
    Related-Bug: #1851362

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/693244
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f2b52b5e8f2579cac2e9cd3844ed3e75d18cd06d
Submitter: Zuul
Branch: master

commit f2b52b5e8f2579cac2e9cd3844ed3e75d18cd06d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Nov 6 19:38:15 2019 +0000

    Add "qos_network_policy_id" to port definition

    Added "qos_network_policy_id" key to port dictionary.

    Change-Id: I75713e0e3924ad4c9177e7c9b04c58882e292dc0
    Closes-Bug: #1851362

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/python-openstackclient 5.1.0 release.