Update mtu of network has no validation

Bug #1848152 reported by Tom Stappaerts
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Tom Stappaerts

Bug Description

When creating a network the mtu value is checked against the type driver of the physical network by calling _get_network_mtu(self, network_db, validate=True) with validate=True.
This check is not performed when doing a network update.

Changed in neutron:
assignee: nobody → Tom Stappaerts (tstappae)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/688656

Changed in neutron:
status: New → In Progress
Hongbin Lu (hongbin.lu)
tags: added: api
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
Slawek Kaplonski (slaweq) wrote : auto-abandon-script

This bug has had a related patch abandoned and has been automatically un-assigned due to inactivity. Please re-assign yourself if you are continuing work or adjust the state as appropriate if it is no longer valid.

Changed in neutron:
assignee: Tom Stappaerts (tstappae) → nobody
status: In Progress → New
tags: added: timeout-abandon
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Slawek Kaplonski (<email address hidden>) on branch: master
Review: https://review.opendev.org/688656
Reason: This review is > 4 weeks without comment, and failed Jenkins the last time it was checked. We are abandoning this for now. Feel free to reactivate the review by pressing the restore button and leaving a 'recheck' comment to get fresh test results.

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Changed in neutron:
assignee: Rodolfo Alonso (rodolfo-alonso-hernandez) → Tom Stappaerts (tstappae)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/688656
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f711090ed3d9b6c449a4fbc8ffe2eac7df6da193
Submitter: Zuul
Branch: master

commit f711090ed3d9b6c449a4fbc8ffe2eac7df6da193
Author: Tom Stappaerts <email address hidden>
Date: Tue Oct 15 10:58:46 2019 +0200

    Check mtu on network update

    When creating a network the mtu of the network is
    checked against the maximum mtu value.
    This should also be done on network update.

    Change-Id: Ie7ea79cb753f360bb0bca7df8484710b5d32ccf7
    Closes-Bug: #1848152

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/train)

Fix proposed to branch: stable/train
Review: https://review.opendev.org/700808

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/train)

Reviewed: https://review.opendev.org/700808
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=8680863ae91e5be0a33039a0607802678b674836
Submitter: Zuul
Branch: stable/train

commit 8680863ae91e5be0a33039a0607802678b674836
Author: Tom Stappaerts <email address hidden>
Date: Tue Oct 15 10:58:46 2019 +0200

    Check mtu on network update

    When creating a network the mtu of the network is
    checked against the maximum mtu value.
    This should also be done on network update.

    Change-Id: Ie7ea79cb753f360bb0bca7df8484710b5d32ccf7
    Closes-Bug: #1848152
    (cherry picked from commit f711090ed3d9b6c449a4fbc8ffe2eac7df6da193)

tags: added: in-stable-train
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/701370

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/701370
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7ecd0fa1a10dc87df248095888948fcec27c1c0d
Submitter: Zuul
Branch: stable/stein

commit 7ecd0fa1a10dc87df248095888948fcec27c1c0d
Author: Tom Stappaerts <email address hidden>
Date: Tue Oct 15 10:58:46 2019 +0200

    Check mtu on network update

    When creating a network the mtu of the network is
    checked against the maximum mtu value.
    This should also be done on network update.

    Change-Id: Ie7ea79cb753f360bb0bca7df8484710b5d32ccf7
    Closes-Bug: #1848152
    (cherry picked from commit f711090ed3d9b6c449a4fbc8ffe2eac7df6da193)

tags: added: in-stable-stein
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.0.2

This issue was fixed in the openstack/neutron 15.0.2 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.1.0

This issue was fixed in the openstack/neutron 14.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.0.0.0b1

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.