new l3 agent router factory breaks neutron-fwaas functional tests

[Nate Johnston]

All of the neutron-fwaas functional tests in class neutron_fwaas.tests.functional.services.logapi.agents.drivers.iptables.test_log.FWLoggingTestCase fail since the release of openstack/neutron 15.0.0.0b1, which includes https://review.opendev.org/620349.

This is because the above change adds a required argument, 'router_factory', for the L3AgentExtensionApi class. The tests in neutron-fwaas were not adjusted to include such an argument. Therefore the following error occurs:

ft1.1: neutron_fwaas.tests.functional.services.logapi.agents.drivers.iptables.test_log.FWLoggingTestCase.test_stop_logging_when_delete_logtesttools.testresult.real._StringException: Traceback (most recent call last):
  File "/home/zuul/src/opendev.org/openstack/neutron-fwaas/neutron_fwaas/tests/functional/services/logapi/agents/drivers/iptables/test_log.py", line 76, in setUp
    self.log_driver = self._initialize_iptables_log()
  File "/home/zuul/src/opendev.org/openstack/neutron-fwaas/neutron_fwaas/tests/functional/services/logapi/agents/drivers/iptables/test_log.py", line 90, in _initialize_iptables_log
    self.agent_api = l3_ext_api.L3AgentExtensionAPI({})
TypeError: __init__() missing 1 required positional argument: 'router_factory'

Source: https://storage.gra1.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_f26/678747/4/gate/neutron-fwaas-functional/f26770c/testr_results.html.gz

[Bence Romsics (bence-romsics)]

To my understanding this was fixed here: https://review.opendev.org/652812. Which was merged already.