Make the MTU attribute not nullable

Bug #1842261 reported by zhanghao
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
zhanghao

Bug Description

mtu attribute is nullable in the network, address all such TODOs
# TODO(ihrachys) remove in Queens+ when mtu is not nullable

then,we can also use reader context instead of writer context in some methods.

Tags: mtu
zhanghao (zhanghao2)
Changed in neutron:
assignee: nobody → zhanghao (zhanghao2)
Changed in neutron:
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
tags: added: mtu
Changed in neutron:
assignee: zhanghao (zhanghao2) → LIU Yulong (dragon889)
Changed in neutron:
assignee: LIU Yulong (dragon889) → zhanghao (zhanghao2)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/679399
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=68625686a40b3eb75502c8116f23d2297e288ca1
Submitter: Zuul
Branch: master

commit 68625686a40b3eb75502c8116f23d2297e288ca1
Author: zhanghao <email address hidden>
Date: Sat Oct 26 16:57:27 2019 -0400

    Make the MTU attribute not nullable

    This patch sets the MTU attribute to non-nullable, the code
    that get the MTU and update the network in some methods can
    be removed. If the MTU is empty before the pike version, it
    is set to the default value of 1500.

    Change-Id: Id4d738dde7fa4b7caccabad0aac542b82b4d7af1
    Closes-Bug: #1842261

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/701380

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/701380
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=08bfbed4c35e0aab95d44619dd7975d969d8acba
Submitter: Zuul
Branch: master

commit 08bfbed4c35e0aab95d44619dd7975d969d8acba
Author: zhanghao <email address hidden>
Date: Mon Jan 6 11:54:12 2020 -0500

    Remove the condition that the mtu is nullable

    The mtu is already non-nullable, it no longer needs to
    judge the mtu when updating the network.
    Related-Bug: #1842261

    Change-Id: Ic097bc2ae50198a3bda45e4a8161c22190ef1964

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 16.0.0.0b1

This issue was fixed in the openstack/neutron 16.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.