Test test_show_network_segment_range failing

[Slawek Kaplonski]

I found it couple of times that neutron_tempest_plugin API test test_show_network_segment_range is failing because there is no project_id field in returned segment data.

Example of failure: http://logs.openstack.org/57/669557/3/check/neutron-tempest-plugin-api/3b8e00b/testr_results.html.gz

Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22line%20209%2C%20in%20test_show_network_segment_range%5C%22 - it failed twice during last week.

As You can see in test code, it's failing in https://github.com/openstack/neutron-tempest-plugin/blob/eaaf978e25b43f49a1f78c34651d4acd65236eeb/neutron_tempest_plugin/api/admin/test_network_segment_range.py#L209 - so this clearly means that there was SOME reply from neutron server as assertions prior to this one were fine.
Also in tempest logs there is logged response like:

Body: b'{"network_segment_range": {"id": "f883f498-1831-4743-819c-eaa04e335fef", "name": "tempest-test_network_segment_range-1876713703", "default": false, "shared": false, "network_type": "vxlan", "minimum": 1100, "maximum": 1105, "revision_number": 0, "description": "", "created_at": "2019-07-08T07:45:18Z", "updated_at": "2019-07-08T07:45:18Z", "available": [1100, 1101, 1102, 1103, 1104, 1105], "used": {}, "tags": []}}'

which don't have project_id in it. Also revision_number=0 looks strange for me.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.opendev.org/671344

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/671344
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7875400f9507ff89c38133b9c37c4471a595afe6
Submitter: Zuul
Branch: master

commit 7875400f9507ff89c38133b9c37c4471a595afe6
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jul 17 17:24:42 2019 +0000

    Check project_id when creating and updating NetworkSegmentRange

    If "shared" is False, a "NetworkSegmentRange" object must have a
    "project_id".

    Change-Id: Ie61117d1a81ab1d0f740ea65bcc003ec88d7af1d
    Related-Bug: #1835914

[Slawek Kaplonski (slaweq)]

@Rodolfo: do we still have this issue after merge of Your patch https://review.opendev.org/671344 ? I didn't saw it recently.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/stein
Review: https://review.opendev.org/722343

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/722343
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2d319eeadccdea14aa0dc2dbd83ad32f4040afb9
Submitter: Zuul
Branch: stable/stein

commit 2d319eeadccdea14aa0dc2dbd83ad32f4040afb9
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Jul 17 17:24:42 2019 +0000

    Check project_id when creating and updating NetworkSegmentRange

    If "shared" is False, a "NetworkSegmentRange" object must have a
    "project_id".

    Change-Id: Ie61117d1a81ab1d0f740ea65bcc003ec88d7af1d
    Related-Bug: #1835914
    (cherry picked from commit 7875400f9507ff89c38133b9c37c4471a595afe6)