neutron-dynamic-routing broken by introduction of agent_timestamp to _log_heartbeat()

[Ryan Tidwell]

neutron-dynamic-routing is broken due to merging https://review.opendev.org/#/c/665426/, which adds the argument 'agent_timestamp' to _log_heartbeat(). All neutron-dynamic-routing jobs are failing with errors like these http://paste.openstack.org/show/753229/.

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Actually this method is used in several projects [1]: networking-old, neutron-dynamic-routing

[1] http://codesearch.openstack.org/?q=create_or_update_agent&i=nope&files=&repos=

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.opendev.org/666654

[Brian Haley (brian-haley)]

https://review.opendev.org/#/c/666224/ was already approved, there was no bug filed since the code had just been submitted.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/666654
Reason: Superseded by https://review.opendev.org/#/c/666224

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/666224
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=0963ce94e01028f8aec3b3af607a2c4d322ec62a
Submitter: Zuul
Branch: master

commit 0963ce94e01028f8aec3b3af607a2c4d322ec62a
Author: Adit Sarfaty <email address hidden>
Date: Wed Jun 19 08:34:16 2019 +0300

    Add default value to agent create_or_update_agent new param

    Commit Ifc88dfb3041aa07b197f395172b69399796ba46a recently added a
    new agent_timestamp parameter to create_or_update_agent.
    As some other projects use this api, the change should have been
    backwards compatible.
    Adding default to None will solve this issue.

    Closes-Bug: #1833589
    Change-Id: I2d17f8eaf4d74ae2081f82e3c1a09bdc80b1d701

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.