neutron

delete_dvr_dst_mac_for_arp uses wrong table id

Bug #1832743 reported by LIU Yulong on 2019-06-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Low	LIU Yulong

Bug Description

ENV: master

Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent [None req-64e6eccc-0d85-4145-923e-de511adf9946 None None] Error while processing VIF ports: TypeError: 'int' object is not iterable
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent Traceback (most recent call last):
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 2398, in rpc_loop
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent port_info, provisioning_needed)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent result = f(*args, **kwargs)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 1965, in process_network_ports
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent port_info['removed'])
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent result = f(*args, **kwargs)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 1875, in treat_devices_removed
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent self.port_unbound(device)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent result = f(*args, **kwargs)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py", line 1186, in port_unbound
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent self.dvr_agent.unbind_port_from_dvr(vif_port, lvm)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/usr/lib/python2.7/site-packages/osprofiler/profiler.py", line 160, in wrapper
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent result = f(*args, **kwargs)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py", line 729, in unbind_port_from_dvr
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent local_vlan_map)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_dvr_neutron_agent.py", line 640, in _unbind_distributed_router_interface_port
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent rtr_port=port.ofport)
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent File "/opt/stack/neutron/neutron/plugins/ml2/drivers/openvswitch/agent/openflow/native/br_int.py", line 209, in delete_dvr_dst_mac_for_arp
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent for table in table_id:
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent TypeError: 'int' object is not iterable
Jun 14 00:30:49 network2 neutron-openvswitch-agent[8378]: ERROR neutron.plugins.ml2.drivers.openvswitch.agent.ovs_neutron_agent

Tags:

LIU Yulong (dragon889) on 2019-06-13

Changed in neutron:
importance:	Undecided → Low
assignee:	nobody → LIU Yulong (dragon889)

LIU Yulong (dragon889) on 2019-06-13

Changed in neutron:
status:	New → Confirmed

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-13: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.opendev.org/665175

Changed in neutron:
status:	Confirmed → In Progress

Revision history for this message

Swaminathan Vasudevan (swaminathan-vasudevan) wrote on 2019-06-13:

Thanks for catching this one.

tags:

added: l3-dvr-backlog

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-15: Fix merged to neutron (master)

Reviewed: https://review.opendev.org/665175
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3027b66c3854c183899e4e0774a92b965aa049d4
Submitter: Zuul
Branch: master

commit 3027b66c3854c183899e4e0774a92b965aa049d4
Author: LIU Yulong <email address hidden>
Date: Fri Jun 14 00:33:58 2019 +0800

Fix mis-use of _dvr_to_src_mac_table_id

    A simple dvr router admin-state down action can cause the
    exception "TypeError: 'int' object is not iterable" in snat
    node ovs-agent. This patch addresses that.

Closes-Bug: #1832743
Change-Id: If31de3cc831b0ee3caed9924e50d86270aeb9d7f

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-09-19: Fix included in openstack/neutron 15.0.0.0b1

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-11-13: Fix proposed to neutron (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/694090

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-11-25: Fix merged to neutron (stable/stein)

Reviewed: https://review.opendev.org/694090
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=52e94d249981457fab587886bc79e38a32de8e36
Submitter: Zuul
Branch: stable/stein

commit 52e94d249981457fab587886bc79e38a32de8e36
Author: LIU Yulong <email address hidden>
Date: Fri Jun 14 00:33:58 2019 +0800

Fix mis-use of _dvr_to_src_mac_table_id

    A simple dvr router admin-state down action can cause the
    exception "TypeError: 'int' object is not iterable" in snat
    node ovs-agent. This patch addresses that.

    Closes-Bug: #1832743
    Change-Id: If31de3cc831b0ee3caed9924e50d86270aeb9d7f
    (cherry picked from commit 3027b66c3854c183899e4e0774a92b965aa049d4)