Port forwarding require always internal_ip_address to be given

Bug #1830554 reported by Slawek Kaplonski
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Slawek Kaplonski

Bug Description

In Neutron API-Ref there is info that internal_ip_address is optional in port_forwarding POST call: https://developer.openstack.org/api-ref/network/v2/index.html?expanded=create-port-forwarding-detail,create-floating-ip-detail#create-port-forwarding

However in API def in neutron-lib, it is mandatory to be set: https://github.com/openstack/neutron-lib/blob/master/neutron_lib/api/definitions/floating_ip_port_forwarding.py#L107 thus when trying to create port forwarding without fixed IP set, it fails.

So api-ref or api definition should be changed.

Revision history for this message
Slawek Kaplonski (slaweq) wrote :

As was agreed on L3 subteam meeting, we should fix api-ref description.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.opendev.org/662207

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.opendev.org/662207
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=c9773782c36a1d8fd19bd400d22c42e96fb63a61
Submitter: Zuul
Branch: master

commit c9773782c36a1d8fd19bd400d22c42e96fb63a61
Author: Slawek Kaplonski <email address hidden>
Date: Thu May 30 15:07:39 2019 +0200

    [api-ref] Update info about internal_ip_address in FIP port forwarding

    Parameter "internal_ip_address" used in floating IP port forwarding
    was wrongly marked as optional as in api definition it is required.
    This patch updates api-ref description to be matched with current
    definition in the code.

    Change-Id: Ib42bed3c5b293c207a8a81f24bd5016f168706fe
    Closes-Bug: #1830554

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lib 1.28.0

This issue was fixed in the openstack/neutron-lib 1.28.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.