[VPNaaS]: Check restart_check_config enabled

[Dongcan Ye]

When neutron-vpn-agent restart, all the pluto process in
router ns will be restarted too, this will impact the vpn traffic.
So in [1] we add a config "restart_check_config" to resolve this problem.

The ipsec.conf.old and ipsec.secrets.old files can only be generated
in config "restart_check_config" enabled, so in restart we should check restart_check_config configuration firstly, then check ipsec.conf and ipsec.secrets changed.

[1] https://bugs.launchpad.net/neutron/+bug/1571455

[Lajos Katona (lajos-katona)]

Could you please add some details like used versions?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/657536
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=8e9572f0712a520bda7c4ef671e14b862e0b0c2d
Submitter: Zuul
Branch: master

commit 8e9572f0712a520bda7c4ef671e14b862e0b0c2d
Author: Dongcan Ye <email address hidden>
Date: Tue May 7 06:49:41 2019 +0000

    Skip check config changed while restart_check_config not enable

    The ipsec.conf.old and ipsec.secrets.old files can only be generated
    if config "restart_check_config" enabled, so in restart we should check
    restart_check_config configuration firstly, then check ipsec.conf and
    ipsec.secrets changed.

    Closes-Bug: #1828721
    Change-Id: Iccaf1aed26f54eeb49ce1cf2cac12a820310968c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 16.0.0.0b1 development milestone.