Check in "_update_segmentation_id" that the mech_driver has an agent

Bug #1824346 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Rodolfo Alonso

Bug Description

In [1] it is assumed that all mechanism drivers have an agent, but the mech driver API [2] doesn't enforce it. An additional check must be done in order to retrieve the "agent_type" instance variable.

[1] https://review.openstack.org/#/c/633165/20/neutron/plugins/ml2/plugin.py@814
[2] https://github.com/openstack/neutron-lib/blob/stable/stein/neutron_lib/plugins/ml2/api.py#L37

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/651878

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Changed in neutron:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.opendev.org/655347

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.opendev.org/651878
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=749b33e41bc905a3bec9d356c78a477e9b8aa87d
Submitter: Zuul
Branch: master

commit 749b33e41bc905a3bec9d356c78a477e9b8aa87d
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Apr 11 12:49:20 2019 +0000

    Check in "_update_segmentation_id" that the mech_driver has an agent

    In [1] it is assumed that all mechanism drivers have an agent, but the
    mech driver API [2] doesn't enforce it. VIF types will be retrieved
    only from those mechanism drivers with an associated agent.

    [1]https://review.openstack.org/#/c/633165/20/neutron/plugins/ml2/plugin.py@814
    [2]https://github.com/openstack/neutron-lib/blob/stable/stein/neutron_lib/plugins/ml2/api.py#L37

    Change-Id: I5c334f31259871ed5251d5d4a2ba8cae36bd2355
    Closes-Bug: #1824346

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 15.0.0.0b1

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.