[neutron][networking-ovn] The function provider_network_attribute_updates_supported is breaking networking-ovn gate

Bug #1823865 reported by Reedip
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Critical
Rodolfo Alonso

Bug Description

Networking-OVN's gate broke [0] after [1] was merged due to the missing definition of provider_network_attribute_updates_supported in [2]. In my opinion, it would serve a better purpose to have this definition in the base class itself.

[0]http://paste.openstack.org/show/749041/. The logs have been retrieved from
http://logs.openstack.org/13/649213/4/check/openstack-tox-py27/a70c92b/job-output.txt.gz#_2019-04-05_11_09_08_715122

[1]I2595335d6fbc51562b070f14eaeaadf49cf7c418

[2]https://github.com/openstack/neutron-lib/blob/master/neutron_lib/plugins/ml2/api.py#L37

Tags: gate-failure
Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/651175

Changed in neutron:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to neutron (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/651177

Changed in neutron:
importance: Undecided → Critical
tags: added: gate-failure
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron-lib (master)

Reviewed: https://review.openstack.org/651175
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=3fd0a3c4d7d54ba438746365653a9d379c842f08
Submitter: Zuul
Branch: master

commit 3fd0a3c4d7d54ba438746365653a9d379c842f08
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Apr 9 09:35:54 2019 +0000

    Rehome provider_network_attribute_updates_supported to API definition

    Rehomed provider_network_attribute_updates_supported to
    plugins.ml2.api.MechanismDriver, in order to be inherited in other
    mechanism drivers.

    Change-Id: I145861b0ca356e3e27495fb2b0205f6e8339a964
    Closes-Bug: #1823865

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron-lib 1.26.0

This issue was fixed in the openstack/neutron-lib 1.26.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on neutron (master)

Change abandoned by Rodolfo Alonso Hernandez (<email address hidden>) on branch: master
Review: https://review.opendev.org/651177
Reason: Addressed in https://review.opendev.org/#/c/655347/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to neutron (master)

Reviewed: https://review.opendev.org/655347
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cfaf5cc1e19a88a9e272967d93b89279284af12c
Submitter: Zuul
Branch: master

commit cfaf5cc1e19a88a9e272967d93b89279284af12c
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Wed Apr 24 07:44:29 2019 +0000

    Rehome provider_network_attribute_updates_supported to API definition

    Rehomed provider_network_attribute_updates_supported to
    plugins.ml2.api.MechanismDriver, in order to be inherited in other
    mechanism drivers.

    Related-Bug: #1823865

    Change-Id: I9be175aa2334111a17d8fec874d2331e23923837

tags: added: neutron-proactive-backport-potential
tags: removed: neutron-proactive-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.