neutron-fullstack fails on stable/rocky at ovs compilation

[Bernard Cafarelli]

A recent behaviour, fullstack now fails on rocky branch in ovs compilation (nf_conntrack_reasm.c file):
/opt/stack/new/ovs/datapath/linux/nf_conntrack_reasm.c:105:31: error: ‘struct inet_frags’ has no member named ‘rnd’
/opt/stack/new/ovs/datapath/linux/nf_conntrack_reasm.c:320:2: error: too many arguments to function ‘inet_frag_kill’

and some other errors.

Sample logs:
http://logs.openstack.org/43/649043/3/check/neutron-fullstack/2310d39/job-output.txt.gz#_2019-04-04_07_45_21_538707
http://logs.openstack.org/40/649540/2/check/neutron-fullstack/77cf080/job-output.txt.gz#_2019-04-04_07_15_54_376644

failing on recent reviews:
https://review.openstack.org/#/c/649043/
https://review.openstack.org/#/c/649540/

[Bernard Cafarelli (bcafarel)]

Same failure also appeared on older branches (smaller impact as fullack is non-voting there), here is a queens failure:
http://logs.openstack.org/48/642348/2/check/neutron-fullstack/a557349/job-output.txt.gz#_2019-04-04_08_53_16_701438

[Bernard Cafarelli (bcafarel)]

From local testing, compilation passes with 4.4.0-143-generic, but fails with new 4.4.0-145-generic kernel

[Bernard Cafarelli (bcafarel)]

It looks like commit 648700f76b03 ("inet: frags: use rhashtables...") that changed how ipv6 fragmentation is implemented was backported in Xenial too, let's use a newer snapshot with https://github.com/openvswitch/ovs/commit/175be4bf23a206b264719b5661707af186b31f32

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/650022

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/650022
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=004caf773abc73661981597abef54dd6389a98c1
Submitter: Zuul
Branch: stable/rocky

commit 004caf773abc73661981597abef54dd6389a98c1
Author: Bernard Cafarelli <email address hidden>
Date: Thu Apr 4 16:24:17 2019 +0200

    Change ovs version we use in fullstack tests

    Kernel 4.4.0-145 backported a change on IPv6 fragmentation API, so
    update the OVS version checked out for fullstack tests to a hash
    including the needed compatibility layer changes

    Change-Id: Ia9383c02e1c62e31db9493729aedbed5b94a3a3f
    Closes-bug: #1823155

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/651318

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/651320

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/651321

[Bernard Cafarelli (bcafarel)]

As suggested in CI meeting, I pushed the backport to older branches. They do not have fullstack voting, but it will be more useful to see failing tests (instead of stopping at compilation)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.3 release.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/651320
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=97522a67d417085081ac043a3d120227e08fbec1
Submitter: Zuul
Branch: stable/pike

commit 97522a67d417085081ac043a3d120227e08fbec1
Author: Bernard Cafarelli <email address hidden>
Date: Thu Apr 4 16:24:17 2019 +0200

    Change ovs version we use in fullstack tests

    Kernel 4.4.0-145 backported a change on IPv6 fragmentation API, so
    update the OVS version checked out for fullstack tests to a hash
    including the needed compatibility layer changes

    Change-Id: Ia9383c02e1c62e31db9493729aedbed5b94a3a3f
    Closes-bug: #1823155
    (cherry picked from commit 004caf773abc73661981597abef54dd6389a98c1)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/651318
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=5dbb26b42305cbb46dbc65a37b07a8f83f26d899
Submitter: Zuul
Branch: stable/queens

commit 5dbb26b42305cbb46dbc65a37b07a8f83f26d899
Author: Bernard Cafarelli <email address hidden>
Date: Thu Apr 4 16:24:17 2019 +0200

    Change ovs version we use in fullstack tests

    Kernel 4.4.0-145 backported a change on IPv6 fragmentation API, so
    update the OVS version checked out for fullstack tests to a hash
    including the needed compatibility layer changes

    Change-Id: Ia9383c02e1c62e31db9493729aedbed5b94a3a3f
    Closes-bug: #1823155
    (cherry picked from commit 004caf773abc73661981597abef54dd6389a98c1)

[Bernard Cafarelli (bcafarel)]

Backport merged up to Pike (and Ocata has W+1, pending recheck), we can consider this one fixed

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/651321
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7b36e4a9aba3d083127b89a46dfd91b68d7cd491
Submitter: Zuul
Branch: stable/ocata

commit 7b36e4a9aba3d083127b89a46dfd91b68d7cd491
Author: Bernard Cafarelli <email address hidden>
Date: Thu Apr 4 16:24:17 2019 +0200

    Change ovs version we use in fullstack tests

    Kernel 4.4.0-145 backported a change on IPv6 fragmentation API, so
    update the OVS version checked out for fullstack tests to a hash
    including the needed compatibility layer changes

    Change-Id: Ia9383c02e1c62e31db9493729aedbed5b94a3a3f
    Closes-bug: #1823155
    (cherry picked from commit 004caf773abc73661981597abef54dd6389a98c1)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.1.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ocata-eol release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron pike-eol release.