neutron-vpn-netns-wrapper not invoked with --rootwrap_config parameter

[Stephen Ma]

The neutron-vpn-netns-wrapper always assumes the rootwrap.conf lives in the default location of /etc/neutron/ because it is not executed with the --rootwrap_config parameter. If rootwrap.conf is not in the default location, then execution will fail with a message like:

2019-03-27 18:06:49.176 13642 INFO neutron.common.config [-] /opt/stack/service/neutron/venv/bin/neutron-vpn-netns-wrapper version 13.0.3.dev77
2019-03-27 18:06:49.177 13642 ERROR neutron_vpnaas.services.vpn.common.netns_wrapper [-] Incorrect configuration file: /etc/neutron/rootwrap.conf: NoOptionError: No option 'filters_path' in section: 'DEFAULT'
; Stderr:

In this case, rootwrap.conf is actually in the non-default directory /opt/stack/service/neutron/etc/.

So all neutron-vpn-netns-wrapper execution should include the --rootwrap_config=<rootwrap_conf_path> argument.

[Bence Romsics (bence-romsics)]

It seems to me the calls to neutron-vpn-netns-wrapper are made here:

http://git.openstack.org/cgit/openstack/neutron-vpnaas/tree/neutron_vpnaas/services/vpn/device_drivers/libreswan_ipsec.py#n48
http://git.openstack.org/cgit/openstack/neutron-vpnaas/tree/neutron_vpnaas/services/vpn/device_drivers/strongswan_ipsec.py#n115

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/648726
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=7e9922858fc36cb890b59232d72cf6e7bcb5957c
Submitter: Zuul
Branch: master

commit 7e9922858fc36cb890b59232d72cf6e7bcb5957c
Author: Stephen Ma <email address hidden>
Date: Fri Mar 29 09:31:03 2019 -0700

    Execute neutron-vpn-netns-wrapper with rootwrap_config argument

    When neutron uses neutron-rootwrap as the root_helper, add
    the --rootwrap_config parameter to neutron-vpn-netns-wrapper
    execution to support environments where rootwrap.conf is not
    in the default location.

    Closes-Bug: #1822199
    Change-Id: I0a345d1b1815560dc4dd35fa5c9a34055fc9fb08

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/656857

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/656858

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/656857
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=4c2ee078b24bb5e5d4279f09797f25df15b95b4d
Submitter: Zuul
Branch: stable/stein

commit 4c2ee078b24bb5e5d4279f09797f25df15b95b4d
Author: Stephen Ma <email address hidden>
Date: Fri Mar 29 09:31:03 2019 -0700

    Execute neutron-vpn-netns-wrapper with rootwrap_config argument

    When neutron uses neutron-rootwrap as the root_helper, add
    the --rootwrap_config parameter to neutron-vpn-netns-wrapper
    execution to support environments where rootwrap.conf is not
    in the default location.

    Closes-Bug: #1822199
    Change-Id: I0a345d1b1815560dc4dd35fa5c9a34055fc9fb08
    (cherry picked from commit 7e9922858fc36cb890b59232d72cf6e7bcb5957c)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/656858
Committed: https://git.openstack.org/cgit/openstack/neutron-vpnaas/commit/?id=af71c17d5153f7cbaba4c4e1e48538728a7d481a
Submitter: Zuul
Branch: stable/rocky

commit af71c17d5153f7cbaba4c4e1e48538728a7d481a
Author: Stephen Ma <email address hidden>
Date: Fri Mar 29 09:31:03 2019 -0700

    Execute neutron-vpn-netns-wrapper with rootwrap_config argument

    When neutron uses neutron-rootwrap as the root_helper, add
    the --rootwrap_config parameter to neutron-vpn-netns-wrapper
    execution to support environments where rootwrap.conf is not
    in the default location.

    Closes-Bug: #1822199
    Change-Id: I0a345d1b1815560dc4dd35fa5c9a34055fc9fb08
    (cherry picked from commit 7e9922858fc36cb890b59232d72cf6e7bcb5957c)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 14.0.1 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron-vpnaas 13.0.2 release.