Network Update if current provider net attribure key/value pair in request

Bug #1822100 reported by Harald Jensås on 2019-03-28
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Rodolfo Alonso

Bug Description

Network initially created with:

{'network': {'provider:physical_network': 'external',
             'provider:network_type': 'flat'}

Network is then updated with:
{'network': {'provider:physical_network': 'external',
             'provider:network_type': 'flat',
             'mtu': 9000}

The net_data is checked for provider attribute's being updated[1], this raises the exception despite the actual values of provider net attributes did not change.

[1] https://github.com/openstack/neutron/blob/af130e79cbe5d12b7c9f9f4dcbcdc8d972bfcfd4/neutron/plugins/ml2/plugin.py#L988

Changed in neutron:
status: New → Incomplete
status: Incomplete → Confirmed
importance: Undecided → Medium
tags: added: api
summary: - Networ Update if current provider net attribure key/value pair in
+ Network Update if current provider net attribure key/value pair in
request

Fix proposed to branch: master
Review: https://review.openstack.org/648522

Changed in neutron:
assignee: nobody → Harald Jensås (harald-jensas)
status: Confirmed → In Progress
Changed in neutron:
assignee: Harald Jensås (harald-jensas) → Rodolfo Alonso (rodolfo-alonso-hernandez)

Reviewed: https://review.openstack.org/648522
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=20743350b9b40fd7a2cff074bb2c877ea36c5914
Submitter: Zuul
Branch: master

commit 20743350b9b40fd7a2cff074bb2c877ea36c5914
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Apr 2 16:57:17 2019 +0100

    Allow provider net attr in update if no change

    If provider net attributes are in update request body,
    do an additional check to see if the values are actually
    different. Only raise exception if values are different.

    Closes-Bug: #1822100
    Co-Authored-By: Rodolfo Alonso Hernandez <email address hidden>

    Change-Id: I4ac11299375d1d3a7d2013f1fdc1742920d884a9

Changed in neutron:
status: In Progress → Fix Released
YAMAMOTO Takashi (yamamoto) wrote :

a networking-midonet unit test needs an update.
https://review.openstack.org/#/c/651062/

Reviewed: https://review.openstack.org/650238
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=234fcd61aa0ed195639769c746acc0e6d318b154
Submitter: Zuul
Branch: stable/stein

commit 234fcd61aa0ed195639769c746acc0e6d318b154
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Apr 2 16:57:17 2019 +0100

    Allow provider net attr in update if no change

    If provider net attributes are in update request body,
    do an additional check to see if the values are actually
    different. Only raise exception if values are different.

    This backport partially picks change:
    I2595335d6fbc51562b070f14eaeaadf49cf7c418. Specifically
    the refactoring replacing the neutron.extensions.providernet
    _raise_if_updates_provider_attributes method with the
    neutron.plugins.ml2.plugin _update_provider_network_attributes
    method.

    Conflicts:
            neutron/extensions/providernet.py
     neutron/plugins/ml2/plugin.py
     neutron/tests/unit/plugins/ml2/test_plugin.py

    Closes-Bug: #1822100
    Co-Authored-By: Rodolfo Alonso Hernandez <email address hidden>

    Change-Id: I4ac11299375d1d3a7d2013f1fdc1742920d884a9
    (cherry picked from commit 20743350b9b40fd7a2cff074bb2c877ea36c5914)

tags: added: in-stable-stein

This issue was fixed in the openstack/neutron 14.0.1 release.

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers