neutron

Misuse of assertTrue/assertFalse

Bug #1819982 reported by Takashi Natsume on 2019-03-14

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	neutron	Fix Released	Low	Takashi Natsume

There are some misuse of assertTrue/assertFalse in unit tests.
They should be fixed.

self.assertTrue(mech_driver, mechanism_test.TestMechanismDriver)

self.assertFalse(event, None)

self.assertFalse(send_events.called, False)

Takashi Natsume (natsume-takashi) on 2019-03-14

Changed in neutron:
assignee:	nobody → Takashi NATSUME (natsume-takashi)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-14: Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/643194

Changed in neutron:
status:	New → In Progress

Slawek Kaplonski (slaweq) on 2019-03-14

Changed in neutron:
importance:	Undecided → Low

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-03-14: Fix merged to neutron (master)

commit 86b3993ceec0c64f4aed02a498fc747ce91eb682
Author: Takashi NATSUME <email address hidden>
Date: Thu Mar 14 09:05:21 2019 +0900

Fix misuse of assertTrue/assertFalse

Change-Id: I247705feeb71e20ad5260b0ca1da08de7290ba6e
Closes-Bug: #1819982

Changed in neutron:
status:	In Progress → Fix Released

Revision history for this message

This issue was fixed in the openstack/neutron 14.0.0.0rc1 release candidate.

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Bug watches keep track of this bug in other bug trackers.