Make "phys_brs" parameter variable in OVSAgentExtensionAPI

Bug #1818693 reported by Rodolfo Alonso
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Rodolfo Alonso

Bug Description

In [1], a new init parameter was introduced in the class OVSAgentExtensionAPI. This change in the extension API can break backwards compatibility with other projects (networking_sfc and bagpipe are affected).

Because this parameter is needed only in qos_driver extension when calling OVSAgentExtensionAPI.request_phy_brs() (to retrieve the physical bridges), we can make this new parameter optional not to break other stadium projects. When the OVS it's initialized (in-tree agent), the extension is called with the three needed parameters.

[1] https://review.openstack.org/#/c/406841/22/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_agent_extension_api.py@43

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/641064

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/641064
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f08de5cbe9695700e282b9882c661353a2c36d74
Submitter: Zuul
Branch: master

commit f08de5cbe9695700e282b9882c661353a2c36d74
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Tue Mar 5 15:59:00 2019 +0000

    Make "phys_brs" argument in OVSAgentExtensionAPI optional

    In [1], a new init parameter was introduced in the class
    OVSAgentExtensionAPI. This change in the extension API can break
    backwards compatibility with other projects (networking_sfc and
    bagpipe are affected).

    Because this parameter is needed only in qos_driver extension when
    calling OVSAgentExtensionAPI.request_phy_brs() (to retrieve the
    physical bridges list), we can make this new parameter optional not
    to break other stadium projects. When the OVS it's initialized
    (in-tree agent), the extension is called with the three needed
    parameters.

    [1] https://review.openstack.org/#/c/406841/22/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_agent_extension_api.py@43

    Change-Id: I31d1a31a935fdcdd12e13e1bc58f7c5f640ca092
    Closes-Bug: #1818693

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b3

This issue was fixed in the openstack/neutron 14.0.0.0b3 development milestone.

tags: added: neutron-proactive-backport-potential
Revision history for this message
Rodolfo Alonso (rodolfo-alonso-hernandez) wrote :

This bug was present only in stable/rocky. This patch is merged in this branch. There is no need to backport this fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.