Functional test test_concurrent_create_port_forwarding_update_port is failing

[Slawek Kaplonski]

Functional test neutron.tests.functional.services.portforwarding.test_port_forwarding.PortForwardingTestCase. test_concurrent_create_port_forwarding_update_port failed at least 2 times in last couple of days.

Failure example: http://logs.openstack.org/48/638648/3/check/neutron-functional/6c3c72d/logs/testr_results.html.gz

Logstash query: http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%20%5C%22line%20457%2C%20in%20test_concurrent_create_port_forwarding_update_port%5C%22

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/644278

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/644278
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=cd6bf8035d9a63e1803e6c763083d3aef0e9408c
Submitter: Zuul
Branch: master

commit cd6bf8035d9a63e1803e6c763083d3aef0e9408c
Author: LIU Yulong <email address hidden>
Date: Mon Mar 18 23:52:18 2019 +0800

    Random IP for concurrent create pf and update_port

    Port forwarding test port IP should be specified, otherwise IP
    collision may happen between new port IP and router interface IP.
    Or sometimes, port new IP and old IP are same.

    After this patch, the port new IP will be randomly choiced from
    the subset without [old_port_ips, router_interface_ips].

    Partially reverts commit 414bdd4c5997886c97d0e3a0b19c684dafeabb7a.

    Change-Id: I157e08288765f1716b4cb12bb2e176760db806c0
    Closes-Bug: #1818334

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 15.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/710446

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.opendev.org/710446
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=c37f5bd4b97b4f1f28e4bf84455deb83b1802947
Submitter: Zuul
Branch: stable/stein

commit c37f5bd4b97b4f1f28e4bf84455deb83b1802947
Author: LIU Yulong <email address hidden>
Date: Mon Mar 18 23:52:18 2019 +0800

    Random IP for concurrent create pf and update_port

    Port forwarding test port IP should be specified, otherwise IP
    collision may happen between new port IP and router interface IP.
    Or sometimes, port new IP and old IP are same.

    After this patch, the port new IP will be randomly choiced from
    the subset without [old_port_ips, router_interface_ips].

    Partially reverts commit 414bdd4c5997886c97d0e3a0b19c684dafeabb7a.

    Change-Id: I157e08288765f1716b4cb12bb2e176760db806c0
    Closes-Bug: #1818334
    (cherry picked from commit cd6bf8035d9a63e1803e6c763083d3aef0e9408c)