neutron

Error message 'Invalid protocol %(protocol)s for port range, only ...' is difficult to understand

Bug #1815478 reported by Andreas Karis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Low
Andreas Karis

Bug Description

Error message 'Invalid protocol %(protocol)s for port range, only ...' is difficult to understand.
~~~
 43 class SecurityGroupInvalidProtocolForPortRange(exceptions.InvalidInput):
 44 message = _("Invalid protocol %(protocol)s for port range, only "
 45 "supported for TCP, UDP, UDPLITE, SCTP and DCCP.")
~~~

Thinking about it logically, the port range is invalid for the protocol, not the other way around.

The error message would be better as:
~~~
Invalid port range specified for protocol %(protocol)s. Do not specify a port range. Port ranges are only supported for TCP, UDP, UDPLITE, SCTP and DCCP.
~~~

Andreas Karis (akaris)
Changed in neutron:
assignee: nobody → Andreas Karis (akaris)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/636174

Changed in neutron:
status: New → In Progress
Akihiro Motoki (amotoki)
Changed in neutron:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/636174
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=d8e8fe7db583d0a32b795c8be5ddfea1dc9ee97d
Submitter: Zuul
Branch: master

commit d8e8fe7db583d0a32b795c8be5ddfea1dc9ee97d
Author: Andreas Karis <email address hidden>
Date: Mon Feb 11 12:04:20 2019 -0500

    Improve invalid port ranges error message

    Improve error message that is shown when
    port ranges are specified for protocols that don't
    support port ranges.

    Change-Id: I70ad9bd01f986efaed6682928cc5579c75bd4f6e
    Closes-Bug: #1815478
    Signed-off-by: Andreas Karis <email address hidden>

Changed in neutron:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 14.0.0.0b2

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/644295

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/644297

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/644300

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/rocky)

Reviewed: https://review.openstack.org/644295
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e813fc8d053b1f04e4a61f220bc14fb008b2fa6e
Submitter: Zuul
Branch: stable/rocky

commit e813fc8d053b1f04e4a61f220bc14fb008b2fa6e
Author: Andreas Karis <email address hidden>
Date: Mon Feb 11 12:04:20 2019 -0500

    Improve invalid port ranges error message

    Improve error message that is shown when
    port ranges are specified for protocols that don't
    support port ranges.

    Change-Id: I70ad9bd01f986efaed6682928cc5579c75bd4f6e
    Closes-Bug: #1815478
    Signed-off-by: Andreas Karis <email address hidden>

tags: added: in-stable-rocky
tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/queens)

Reviewed: https://review.openstack.org/644297
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=eb857c8e9d2ca1791c5b8901121d1a6559dbeb91
Submitter: Zuul
Branch: stable/queens

commit eb857c8e9d2ca1791c5b8901121d1a6559dbeb91
Author: Andreas Karis <email address hidden>
Date: Mon Feb 11 12:04:20 2019 -0500

    Improve invalid port ranges error message

    Improve error message that is shown when
    port ranges are specified for protocols that don't
    support port ranges.

    Change-Id: I70ad9bd01f986efaed6682928cc5579c75bd4f6e
    Closes-Bug: #1815478
    Signed-off-by: Andreas Karis <email address hidden>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/pike)

Reviewed: https://review.openstack.org/644300
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=bfdd867580fe21911a810d2a256215ff1ec5565e
Submitter: Zuul
Branch: stable/pike

commit bfdd867580fe21911a810d2a256215ff1ec5565e
Author: Andreas Karis <email address hidden>
Date: Mon Feb 11 12:04:20 2019 -0500

    Improve invalid port ranges error message

    Improve error message that is shown when
    port ranges are specified for protocols that don't
    support port ranges.

    Change-Id: I70ad9bd01f986efaed6682928cc5579c75bd4f6e
    Closes-Bug: #1815478
    Signed-off-by: Andreas Karis <email address hidden>

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 11.0.7

This issue was fixed in the openstack/neutron 11.0.7 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 13.0.3

This issue was fixed in the openstack/neutron 13.0.3 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/neutron 12.0.6

This issue was fixed in the openstack/neutron 12.0.6 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.