Port with no active binding mark as dead

Bug #1812788 reported by Pawel Suder on 2019-01-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Medium
Pawel Suder

Bug Description

In change

- https://github.com/openstack/neutron/commit/5c3bf124966a310cbc6c8ffad5ab30b144d9d7aa#diff-9cca2f63ca397a7e93909a7119fdd16fL1582
- https://review.openstack.org/#/c/574058/

port is mark as dead in both cases:

- c_const.NO_ACTIVE_BINDING in details
- c_const.NO_ACTIVE_BINDING not in details

Question: Should be port mark as dead in first case?

Proposed change: https://review.openstack.org/#/c/632045

Tags: ovs Edit Tag help
Changed in neutron:
assignee: nobody → Pawel Suder (pasuder)
status: New → In Progress
Lajos Katona (lajos-katona) wrote :

Hi Pawel,
Could you please add some longer description?
How does it affect device handling if we leave as it is now (mark as dead for both cases)?

If I understand well port should be dead only in case of port IS NOT IN DETAILS, am I right?

Pawel Suder (pasuder) wrote :

Hello Lajos, I raised that bug as per Slawek proposed in review https://review.openstack.org/#/c/632045/

I would like to ensure if Miguel did correctly refactor in https://review.openstack.org/#/c/574058/15/neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py in R1606-1607.

It was a part of RFE: https://bugs.launchpad.net/neutron/+bug/1580880

I do not know if port should be dead if there is no 'port_id' in details AND no c_const.NO_ACTIVE_BINDING in details.

That's why this bug is opened to validate it.

Lajos Katona (lajos-katona) wrote :

Hi Pawel,
Ok, it is much clear then.

Changed in neutron:
importance: Undecided → Medium
tags: added: ovs

Change abandoned by Paweł Suder (<email address hidden>) on branch: master
Review: https://review.openstack.org/632045
Reason: Thank you Miguel for clarification :))

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers