[l3] `port_forwarding` cannot be set before l3 `router` in service_plugins

[LIU Yulong]

ENV:
devstack master

Exception:
http://paste.openstack.org/show/737781/

How to reproduce:
In neutron.conf just set `port_forwarding` plugin before l3 `router` plugin, and then create port forwarding,
something like this:

[DEFAULT]
service_plugins = port_forwarding,router

then you will get that exception in neutron server log.

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/626538

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/626561

[Slawek Kaplonski (slaweq)]

So, are You saying that in this case order of service plugins is important? If so, I think that this should be changed somehow because we don't have anything in docs about ordering service plugins.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626538
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=76c28812013c558041612609efe30b88a5226267
Submitter: Zuul
Branch: master

commit 76c28812013c558041612609efe30b88a5226267
Author: LIU Yulong <email address hidden>
Date: Mon Dec 17 10:35:33 2018 +0800

    Make test service_plugins override simple

    Just make things simple and give a chance to accept that
    ordered 'service_plugins' list or tuple for the base test
    class NeutronDbPluginV2TestCase.

    Change-Id: I7c352ede811703e3a96848378b92cbbf5e109228
    Related-Bug: #1809238

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626561
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=e8b7e768a2545621ee98511b8dd271c5117f76bd
Submitter: Zuul
Branch: master

commit e8b7e768a2545621ee98511b8dd271c5117f76bd
Author: LIU Yulong <email address hidden>
Date: Mon Dec 17 11:38:20 2018 +0800

    Add dependency for service plugin

    Adds a required list 'required_service_plugins' to each service plugin,
    then we can initialize the service plugin with required dependency.
    And also adds the 'router' plugin to port forwarding service plugin
    required list.

    Closes-Bug: #1809238
    Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/649042

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: stable/rocky
Review: https://review.openstack.org/651759

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/651759
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=21bbe03619a7036ccf61a8012355b8972d660b86
Submitter: Zuul
Branch: stable/rocky

commit 21bbe03619a7036ccf61a8012355b8972d660b86
Author: LIU Yulong <email address hidden>
Date: Mon Dec 17 10:35:33 2018 +0800

    Make test service_plugins override simple

    Just make things simple and give a chance to accept that
    ordered 'service_plugins' list or tuple for the base test
    class NeutronDbPluginV2TestCase.

    Change-Id: I7c352ede811703e3a96848378b92cbbf5e109228
    Related-Bug: #1809238
    (cherry picked from commit 76c28812013c558041612609efe30b88a5226267)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/649042
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2331e5fefc727bd6ed1e52d83baf253b195ef628
Submitter: Zuul
Branch: stable/rocky

commit 2331e5fefc727bd6ed1e52d83baf253b195ef628
Author: LIU Yulong <email address hidden>
Date: Mon Dec 17 11:38:20 2018 +0800

    Add dependency for service plugin

    Adds a required list 'required_service_plugins' to each service plugin,
    then we can initialize the service plugin with required dependency.
    And also adds the 'router' plugin to port forwarding service plugin
    required list.

    Conflicts:
        neutron/tests/unit/extensions/test_floating_ip_port_forwarding.py

    Closes-Bug: #1809238
    Change-Id: I53fdaee0cd96a5315a7abc39799657d613eb3a2e
    (cherry picked from commit e8b7e768a2545621ee98511b8dd271c5117f76bd)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.4 release.