TypeError in QoS gateway_ip code in l3-agent logs

[Brian Haley]

Seeing this traceback in the l3-agent logs in the failing neutron-tempest-plugin-dvr-multinode-scenario job.

For example,
http://logs.openstack.org/23/622623/3/check/neutron-tempest-plugin-dvr-multinode-scenario/604b3c0/controller/logs/screen-q-l3.txt.gz?level=WARNING

neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent [-] Error while deleting router da35128f-c2e4-4bc5-a409-a07f60970be1: TypeError: string indices must be integers
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent Traceback (most recent call last):
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/agent.py", line 398, in _safe_router_removed
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent self.l3_ext_manager.delete_router(self.context, router_id)
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/l3_agent_extensions_manager.py", line 66, in delete_router
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent extension.obj.delete_router(context, data)
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent File "/opt/stack/neutron/neutron/agent/l3/extensions/qos/gateway_ip.py", line 99, in delete_router
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent self.gateway_ip_qos_map.clean_by_resource(data['id'])
neutron-l3-agent[13439]: ERROR neutron.agent.l3.agent TypeError: string indices must be integers

This could be one of the reasons the job is failing.

[Brian Haley (brian-haley)]

Looking at the log again, the error is being caught, so this isn't causing the job failure, but it is in the log a lot.

[Brian Haley (brian-haley)]

_safe_router_removed() is not honoring the l3_ext_manager API, it needs to pass a router dict in delete_router() and not just the id. I'll work on a fix.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/626401

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626401
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e
Submitter: Zuul
Branch: master

commit 4bb78e8c215d24cd2fc9168e7bfbb47ceb89de3e
Author: Brian Haley <email address hidden>
Date: Wed Dec 19 16:55:47 2018 -0500

    Fix l3-agent usage of L3AgentExtension class

    The L3AgentExtension class delete_router() method expects a
    dict as it's 'data' argument, but the l3-agent code that
    deletes a router was passing just the router ID. Change to
    correctly pass a router dictionary if one exists.

    Change-Id: I112d1f8dce9defddfbd8fbfa75bf538e308e1561
    Closes-bug: #1809134

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b2 development milestone.