l2 pop doesn't always provide the whole list of fdb entries on OVS restart

[Oleg Bondarev]

bug https://bugs.launchpad.net/neutron/+bug/1804842 was fixed, but there is still a race condition, which leads to the same issue:

success scenario:
 - OVS is restarted
 - agent start_flag set to True
 - report state done
 - ports updated, server sends fdb entries as it sees agent as restarted

fail scenario:
 - OVS is restarted
 - agent start_flag set to True
 - ports updated, server doesn't send fdb entries as report state with start flag has not yet come
 - report state done
 - no fdb entries on agent (since no update port messages to server within config.agent_boot_time sec)

The proposal is to force state report right after setting start_flag.
No side effects expected.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/624669

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/624669
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=3995abefb16181594181133b271cdf35fa8d9937
Submitter: Zuul
Branch: master

commit 3995abefb16181594181133b271cdf35fa8d9937
Author: Oleg Bondarev <email address hidden>
Date: Wed Dec 12 15:11:43 2018 +0400

    Do state report after setting start_flag on OVS restart

    This fixes race condition leading to lack of fdb entries
    on agent after OVS restart, if agent managed to handle all ports
    before sending state report with start_flag set to True.

    Change-Id: I943f8d805630cdfbefff9cff1fb4bce89210618b
    Closes-Bug: #1808136

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/626102

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/626521

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/626545

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626102
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6a56d3879837999edca48f5496d4acc7dde8b37e
Submitter: Zuul
Branch: stable/rocky

commit 6a56d3879837999edca48f5496d4acc7dde8b37e
Author: Oleg Bondarev <email address hidden>
Date: Wed Dec 12 15:11:43 2018 +0400

    Do state report after setting start_flag on OVS restart

    This fixes race condition leading to lack of fdb entries
    on agent after OVS restart, if agent managed to handle all ports
    before sending state report with start_flag set to True.

    Change-Id: I943f8d805630cdfbefff9cff1fb4bce89210618b
    Closes-Bug: #1808136
    (cherry picked from commit 3995abefb16181594181133b271cdf35fa8d9937)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626521
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=282eadc68f8713fdc8b6cac505e4a5e27d2a7450
Submitter: Zuul
Branch: stable/queens

commit 282eadc68f8713fdc8b6cac505e4a5e27d2a7450
Author: Oleg Bondarev <email address hidden>
Date: Wed Dec 12 15:11:43 2018 +0400

    Do state report after setting start_flag on OVS restart

    This fixes race condition leading to lack of fdb entries
    on agent after OVS restart, if agent managed to handle all ports
    before sending state report with start_flag set to True.

    Change-Id: I943f8d805630cdfbefff9cff1fb4bce89210618b
    Closes-Bug: #1808136
    (cherry picked from commit 3995abefb16181594181133b271cdf35fa8d9937)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626545
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=329de01d09cdb56a06db3d01c8972052b575239d
Submitter: Zuul
Branch: stable/pike

commit 329de01d09cdb56a06db3d01c8972052b575239d
Author: Oleg Bondarev <email address hidden>
Date: Wed Dec 12 15:11:43 2018 +0400

    Do state report after setting start_flag on OVS restart

    This fixes race condition leading to lack of fdb entries
    on agent after OVS restart, if agent managed to handle all ports
    before sending state report with start_flag set to True.

    Change-Id: I943f8d805630cdfbefff9cff1fb4bce89210618b
    Closes-Bug: #1808136
    (cherry picked from commit 3995abefb16181594181133b271cdf35fa8d9937)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/640176

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/640176
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=ffa3e75269b29714550e93c91a63d5fca44922df
Submitter: Zuul
Branch: stable/ocata

commit ffa3e75269b29714550e93c91a63d5fca44922df
Author: Oleg Bondarev <email address hidden>
Date: Wed Dec 12 15:11:43 2018 +0400

    Do state report after setting start_flag on OVS restart

    This fixes race condition leading to lack of fdb entries
    on agent after OVS restart, if agent managed to handle all ports
    before sending state report with start_flag set to True.

    Change-Id: I943f8d805630cdfbefff9cff1fb4bce89210618b
    Closes-Bug: #1808136
    (cherry picked from commit 3995abefb16181594181133b271cdf35fa8d9937)
    (cherry picked from commit 329de01d09cdb56a06db3d01c8972052b575239d)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 11.0.7 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 13.0.3 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 12.0.6 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron ocata-eol release.