Table name in "add_ip_rule" can be a string

Bug #1807128 reported by Rodolfo Alonso on 2018-12-06
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Low
Rodolfo Alonso

Bug Description

In neutron.agent.linux.ip_lib.add_ip_rule, the "table" argument can be an integer or a string ("default", "main", "local").

This parameter is incorrectly treated in "_make_pyroute2_args".

Fix proposed to branch: master
Review: https://review.openstack.org/623182

Changed in neutron:
assignee: nobody → Rodolfo Alonso (rodolfo-alonso-hernandez)
status: New → In Progress
Bence Romsics (bence-romsics) wrote :

If I'm reading this right a slight type error slipped through in I0cc6b24a91794eeba46462fac2bfdeda2ba2ab9e that was merged a bit ago. So the new ip_lib code being fixed here is not in use yet, right? That's why I'm setting the importance to low.

Changed in neutron:
importance: Undecided → Low

Hi @Bence:

The code is in use, but the "table" parameter is always passed as an int. Currently no calls to this function are made using a string parameter ("default", "main", "local"). This in an extra added in this patch for future developments.

Reviewed: https://review.openstack.org/623182
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=89ba2416f26fc4255bc1cd9f01d68bf18fe73b95
Submitter: Zuul
Branch: master

commit 89ba2416f26fc4255bc1cd9f01d68bf18fe73b95
Author: Rodolfo Alonso Hernandez <email address hidden>
Date: Thu Dec 6 10:48:51 2018 +0000

    Table name in "add_ip_rule" can be a string

    In neutron.agent.linux.ip_lib.add_ip_rule, the "table" argument can be
    an integer or a string ("default", "main", "local").

    This parameter is incorrectly treated in "_make_pyroute2_args".

    Change-Id: I0a50af5fe9b1550700e607eb680bb16e5044e8ef
    Closes-Bug: #1807128

Changed in neutron:
status: In Progress → Fix Released

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers