[RFE] Add a config option rpc_response_max_timeout

[nicky]

We want to add a new configuration option rpc_response_max_timeout to
neutron.conf.

The rpc_response_max_timeout plays a role of the ceiling of timeout
seconds when waiting for the response of a remote rpc server.

During an RPC call, the waiting time starts from the existing parameter
rpc_response_timeout(default 60s) and doubled each time until it reaches
the ceiling which is currently set as 10 times rpc_response_timeout.
It seems to be less flexible since user cannot directly change the
ceiling value unless he/she changes the rpc_response_timeout. By adding
rpc_response_max_timeout, user can now modify it without changing
any other parameters.

[Miguel Lavalle (minsel)]

Can you provide some more information on why the current way if handling this "is not reasonable"? Marking it as incomplete for the time being

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/621740

[nicky (ss104301)]

In the current version, users cannot directly change the max timeout of an rpc client. The value is just rpc_response_timeout (already in neutron.conf) times 10, which is way too long and inflexible.

It may be improved by adding a new configuration to neutron.conf to let user decide what the max timeout is. Uses now can modify this value without changing the value of rpc_response_timeout.

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/621740

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/622075

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/621062

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/622854

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/622075

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/622854

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/622897

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/622897

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/623114

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/623163

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/623163

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/623369

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/623369

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/623393

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/623114

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/623401

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/623393

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/626109

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/626119

[OpenStack Infra (hudson-openstack)]

Change abandoned by nicky (<email address hidden>) on branch: master
Review: https://review.openstack.org/626119

[Slawek Kaplonski (slaweq)]

As this is proposal to add new config option, I think that it should be handled as RFE and discussed by drivers team before we will start merging code.

[Miguel Lavalle (minsel)]

This RFE was discussed and approved during today's meeting

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/626109
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=f1592c42d9649e8da952021aa1f6e7a4a127cd48
Submitter: Zuul
Branch: master

commit f1592c42d9649e8da952021aa1f6e7a4a127cd48
Author: nicky <email address hidden>
Date: Wed Dec 19 16:07:05 2018 +0800

    Add a new configuration parameter rpc_response_max_timeout

    A new parameter rpc_response_max_timeout is added and registered into
    neutron.conf.

    The rpc_response_max_timeout plays a role of the ceiling of timeout
    seconds when waiting for the response of a remote rpc server.

    During an RPC call, the waiting time starts from the existing parameter
    rpc_response_timeout(default 60s) and doubled each time until it reaches
    the ceiling which is currently set as 10 times rpc_response_timeout.
    It seems to be less flexible since user cannot directly change the
    ceiling value unless he/she changes the rpc_response_timeout.
    By adding rpc_response_max_timeout, user can now modify it without
    changing any other parameters.

    Co-Authored-By: Allain Legacy<email address hidden>

    Change-Id: I170113c2946cc95308edcb1a703a99c71e50b6f9
    Related-Bug: #1805769
    Story: 2004456
    Task: 28171

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/623401
Committed: https://git.openstack.org/cgit/openstack/neutron-lib/commit/?id=af902dfb2ac8e5bc253af8fb85bc4d0f61bdfa56
Submitter: Zuul
Branch: master

commit af902dfb2ac8e5bc253af8fb85bc4d0f61bdfa56
Author: nicky <email address hidden>
Date: Thu Dec 20 13:24:00 2018 +0800

    Add a new configuration parameter rpc_response_max_timeout

    A new parameter rpc_response_max_timeout is added and registered into
    neutron.conf. (related codes in neutron)

    The rpc_response_max_timeout plays a role of the ceiling of timeout
    seconds when waiting for the response of a remote rpc server.

    During an RPC call, the waiting time starts from the existing parameter
    rpc_response_timeout(default 60s) and doubled each time until it reaches
    the ceiling which is currently set as 10 times rpc_response_timeout.
    It seems to be less flexible since user cannot directly change the
    ceiling value unless he/she changes the rpc_response_timeout.

    By adding rpc_response_max_timeout, user can now modify it without
    changing any other parameters.

    In class _BackingOffContextWrapper, _max_timeout and its setters are
    useless temporarily because users can now directly change the rpc_max_
    timeout in neutron.conf. However, there're not deleted as we should not
    prevent the developer to override this parameter.

    Co-Authored-By: Allain Legacy<email address hidden>

    Change-Id: I45d2e5c063d2dd43cb8aec1d46faa3ee8ea4825f
    Depends-on: https://review.openstack.org/#/c/626109
    Related-Bug: #1805769
    Story: 2004456
    Task: 28171