Convert instance method to staticmethod in linux bridge agent

[Yang Youseok]

There were many instance methods unnecessarily maintained in linuxbridge_neutron_agent. I found it makes L2 extensions hard to use those functionality(e.g. get_all_devices()), so if there is no strong reasons to use instance method, it's better to fix it.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/620277

[Rodolfo Alonso (rodolfo-alonso-hernandez)]

Hello Yang:

Please, can you provide an example of where "get_all_devices()" is hard to use?

Anyway, I think the patch submitted is valid.

[Yang Youseok (ileixe)]

@Alonso

Hello Alonso. Sorry for my inaccurate expression. I mean I have to instantiate LinuxBridgeManager class to use get_all_devices() function in extension.

Honestly, imho it's better to refactor those static functions though, making staticmethod is compromising for now.

[Miguel Lavalle (minsel)]

Can you clarify a little more. What is wrong with instantiating the driver? How are you planning to use those methods?

[Yang Youseok (ileixe)]

@Miguel

Hello, Miguel. This is gist for our L2 extension.

https://gist.github.com/Xeite/717f5823e3577f9ee612e63543a64e8d

In fact, I only use 'LinuxBridgeManager.get_all_devices()' for the changed code.

Now, I wonder it's not promoted to use LinuxBridgeManager functions in L2 extensions. Let me know if it is.

Thanks.

[Yang Youseok (ileixe)]

https://gist.github.com/Xeite/717f5823e3577f9ee612e63543a64e8d#file-fib_population-py-L68 for the exact location.

[Miguel Lavalle (minsel)]

Fair enough! Thanks for the follow up

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/620277
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=aaf215b5a59a7e22961d1c155d86367e35e78f87
Submitter: Zuul
Branch: master

commit aaf215b5a59a7e22961d1c155d86367e35e78f87
Author: Yang Youseok <email address hidden>
Date: Tue Nov 27 18:39:26 2018 +0900

    Convert instance method to staticmethod in linuxbridge_neutron_agent

    Convert unnessary instance method to staticmethod so that any plugin
    API can use the methods.

    Closes-Bug: #1805356
    Change-Id: Ic568f470b813b85cfa46aa46308480e2579f779c

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/neutron 14.0.0.0b1 development milestone.